You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Guosmilesmile (via GitHub)" <gi...@apache.org> on 2026/01/02 15:20:29 UTC
[PR] Flink: Fix equalityFieldColumns always null in IcebergSink [iceberg]
Guosmilesmile opened a new pull request, #14952:
URL: https://github.com/apache/iceberg/pull/14952
Currently, `equalityFieldColumns` in `IcebergSink` is always null, because although the builder holds `equalityFieldColumns` and converts it to `equalityFieldColumnIds` before passing it to `IcebergSink`, the raw `equalityFieldColumns` list is only used in log statements. Hence, no issue has surfaced so far.
This PR fixes the issue where `equalityFieldColumns` is always null, ensuring that the parameter can be correctly printed in the logs when problems occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix equalityFieldColumns always null in IcebergSink [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #14952:
URL: https://github.com/apache/iceberg/pull/14952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix equalityFieldColumns always null in IcebergSink [iceberg]
Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #14952:
URL: https://github.com/apache/iceberg/pull/14952#discussion_r2661578316
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##########
@@ -162,7 +163,7 @@ public class IcebergSink
private final transient FlinkMaintenanceConfig flinkMaintenanceConfig;
private final Table table;
- private final Set<String> equalityFieldColumns = null;
+ private final Set<String> equalityFieldColumns;
Review Comment:
Yes, have added a comment for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix equalityFieldColumns always null in IcebergSink [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #14952:
URL: https://github.com/apache/iceberg/pull/14952#issuecomment-3714521662
Merged to main.
Thanks @Guosmilesmile for the PR and @singhpk234, @huaxingao and @ebyhr for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix equalityFieldColumns always null in IcebergSink [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #14952:
URL: https://github.com/apache/iceberg/pull/14952#discussion_r2661500131
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##########
@@ -162,7 +163,7 @@ public class IcebergSink
private final transient FlinkMaintenanceConfig flinkMaintenanceConfig;
private final Table table;
- private final Set<String> equalityFieldColumns = null;
+ private final Set<String> equalityFieldColumns;
Review Comment:
Could we leave a comment that this should only be used for logging, and `equalityFieldIds` should be used instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org