You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "riyaverm-db (via GitHub)" <gi...@apache.org> on 2024/05/28 21:16:44 UTC
[PR] [SPARK-48442] [PYSPARK] Add parenthesis to awaitTermination [spark]
riyaverm-db opened a new pull request, #46779:
URL: https://github.com/apache/spark/pull/46779
### Why are the changes needed?
In `test_stream_reader` and `test_stream_writer` of `test_python_streaming_datasource.py`, the call `q.awaitTermination` does not invoke a function call as intended, but instead returns a python function object. The fix is to change this to `q.awaitTermination()`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tests were not added since it is correcting a bug in a test file.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48442][PYTHON][TESTS] Add parenthesis to awaitTermination [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46779:
URL: https://github.com/apache/spark/pull/46779#issuecomment-2138408467
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48442][PYTHON][TESTS] Add parenthesis to awaitTermination [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #46779: [SPARK-48442][PYTHON][TESTS] Add parenthesis to awaitTermination
URL: https://github.com/apache/spark/pull/46779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] [SPARK-48442] [PYSPARK] Add parenthesis to awaitTermination [spark]
Posted by "riyaverm-db (via GitHub)" <gi...@apache.org>.
riyaverm-db commented on PR #46779:
URL: https://github.com/apache/spark/pull/46779#issuecomment-2136209502
@chaoqin-li1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org