[GitHub] [cassandra] pauloricardomg commented on a diff in pull request #1351: CASSANDRA-17180

[GitBox <gi...@apache.org>]

pauloricardomg commented on code in PR #1351:
URL: https://github.com/apache/cassandra/pull/1351#discussion_r853322724


##########
conf/cassandra.yaml:
##########
@@ -1687,4 +1687,8 @@ drop_compact_storage_enabled: false
 #    enabled: true # (overriden by cassandra.ignore_dc system property)
 #  rack:
 #    enabled: true # (overriden by cassandra.ignore_rack system property)
-
+#  gc_grace_period:

Review Comment:
   agreed. i don’t like this format of configuration since it’s not immediately clear to uses what each startup check does.
   
   I think we should use the following format for startup checks to make it easier for users to reason about:
   
   ```
   check_dc:
       enabled: true
   check_rack:
       enabled: true
   check_data_resurrection:
       enabled: true
       foo: bar
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org