You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/02 10:10:09 UTC

[GitHub] flink pull request #4460: [FLINK-7349] [travis] Only execute checkstyle in m...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4460

    [FLINK-7349] [travis] Only execute checkstyle in misc profile

    ## What is the purpose of the change
    
    Improve travis build times by skipping redundant checkstyle executions.
    
    ## Brief change log
    
      - refactor mvn configuration in travis watchdog script
      - add `-Dcheckstyle.skip=true` to core/libraries/connector/tests profile options
    
    
    ## Verifying this change
    
    Add a checkstyle violation and let it run of travis, it should only fail in 1 profile (i.e. 2 builds)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4460
    
----
commit 4730355b9efa4169f4739681999c16000d9eb3bd
Author: zentol <ch...@apache.org>
Date:   2017-08-02T10:05:56Z

    [FLINK-7349] [travis] Only execute checkstyle in misc profile

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4460: [FLINK-7349] [travis] Only execute checkstyle in misc pro...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4460
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4460: [FLINK-7349] [travis] Only execute checkstyle in misc pro...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4460
  
    +1; looks to be 20 to 30 minutes faster than recent test jobs on master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4460: [FLINK-7349] [travis] Only execute checkstyle in m...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4460


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---