[GitHub] [flink] slinkydeveloper commented on a change in pull request #18272: [FLINK-25525][FLINK-25487][table] Various fixed related to the new planner-loader

[GitBox <gi...@apache.org>]

slinkydeveloper commented on a change in pull request #18272:
URL: https://github.com/apache/flink/pull/18272#discussion_r778991231



##########
File path: flink-table/flink-table-planner/pom.xml
##########
@@ -196,14 +189,15 @@ under the License.
 			<!-- For legacy string expressions in Table API -->
 			<groupId>org.scala-lang.modules</groupId>
 			<artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
+			<scope>provided</scope>
 		</dependency>
 
 		<dependency>
 			<!-- Utility to scan classpaths -->
 			<groupId>org.reflections</groupId>
 			<artifactId>reflections</artifactId>
 			<version>0.9.10</version>
-			<scope>compile</scope>
+			<scope>provided</scope>

Review comment:
       Check `ReflectionsUtil`. We can get rid of this dep once during the FLIP-190 related work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org