You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2017/03/20 17:35:07 UTC
[GitHub] zeppelin pull request #2168: [ZEPPELIN-1889] [FIX] Multiple groups in chart ...
GitHub user sravan-s opened a pull request:
https://github.com/apache/zeppelin/pull/2168
[ZEPPELIN-1889] [FIX] Multiple groups in chart doesn't work
### What is this PR for?
Fix for multiple group in multi-bar chart
If any value is missing under any domain key in stacked multi-bar chart,
it won't get rendered. Fix this bug by adding `fillMissingValues` flag in
`d3DataFromPivot()`
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889)
### How should this be tested?
* Create a paragraph with tabular output
* Add multiple groups to input
* Render the stacked multi bar chart
* Chart should be rendered properly
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-1889-multiple-groups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2168
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2168: [ZEPPELIN-1889] [FIX] Multiple groups in chart doesn't...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2168
Thanks for working on the issue.
I have tested problem [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889) in current master. However i couldn't reproduce the problem.
@zjffdu @sravan-s Is problem described in ZEPPELIN-1889 is reproducible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2168: [ZEPPELIN-1889] [FIX] Multiple groups in chart doesn't...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2168
Thanks @sravan-s for clarify.
Tested and it works well.
Merge to master and branch-0.7 if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2168: [ZEPPELIN-1889] [FIX] Multiple groups in chart ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2168: [ZEPPELIN-1889] [FIX] Multiple groups in chart doesn't...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2168
@Leemoonsoo , the bug is limited only for 'stacked' version of bar chart. Notice the radio button inside the chart
* This is the grouped version
* This is the buggy stacked version, in some cases, it won't even get rendered
* This is the fixed stacked version
p.s. I tried recording gifs, but my laptop hangs(ubuntu 16.04, but I think it's the hardware that's the culprit)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---