You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "kojiromike (via GitHub)" <gi...@apache.org> on 2023/07/18 23:15:33 UTC
[GitHub] [avro] kojiromike opened a new pull request, #2367: AVRO-1737 Test that Schema are Hashable
kojiromike opened a new pull request, #2367:
URL: https://github.com/apache/avro/pull/2367
This test should fail right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] github-code-scanning[bot] commented on a diff in pull request #2367: AVRO-1737 Test that Schema are Hashable
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #2367:
URL: https://github.com/apache/avro/pull/2367#discussion_r1267407859
##########
lang/py/avro/schema.py:
##########
@@ -247,6 +247,10 @@
@return bool
"""
+ def __hash__(self) -> int:
Review Comment:
## Inconsistent equality and hashing
Class [Schema](1) implements __hash__ but does not define __eq__.
Class [NamedSchema](2) implements __hash__ but does not define __eq__.
Class [PrimitiveSchema](3) implements __hash__ but does not define __eq__.
Class [BytesDecimalSchema](4) implements __hash__ but does not define __eq__.
Class [FixedSchema](5) implements __hash__ but does not define __eq__.
Class [FixedDecimalSchema](6) implements __hash__ but does not define __eq__.
Class [EnumSchema](7) implements __hash__ but does not define __eq__.
Class [ArraySchema](8) implements __hash__ but does not define __eq__.
Class [MapSchema](9) implements __hash__ but does not define __eq__.
Class [UnionSchema](10) implements __hash__ but does not define __eq__.
Class [ErrorUnionSchema](11) implements __hash__ but does not define __eq__.
Class [RecordSchema](12) implements __hash__ but does not define __eq__.
Class [DateSchema](13) implements __hash__ but does not define __eq__.
Class [TimeMillisSchema](14) implements __hash__ but does not define __eq__.
Class [TimeMicrosSchema](15) implements __hash__ but does not define __eq__.
Class [TimestampMillisSchema](16) implements __hash__ but does not define __eq__.
Class [TimestampMicrosSchema](17) implements __hash__ but does not define __eq__.
Class [UUIDSchema](18) implements __hash__ but does not define __eq__.
[Show more details](https://github.com/apache/avro/security/code-scanning/3039)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike merged pull request #2367: AVRO-1737 Implement Hashable for Schema
Posted by "kojiromike (via GitHub)" <gi...@apache.org>.
kojiromike merged PR #2367:
URL: https://github.com/apache/avro/pull/2367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org