You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/09 02:44:29 UTC

[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #1653: Remove @Data annotation and add @TableField annotation

lenboo commented on a change in pull request #1653: Remove @Data annotation and add @TableField annotation
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1653#discussion_r364537700
 
 

 ##########
 File path: dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java
 ##########
 @@ -77,14 +76,7 @@ public void testInsert() throws Exception{
     @Test
     public void testSelectById() throws Exception{
         Integer userId = 1;
-
-        AccessToken accessToken = createAccessToken(userId);
-
-        AccessToken resultAccessToken
-                = accessTokenMapper.selectById(accessToken.getId());
 
 Review comment:
   you are right. but we can optimize rather than delete them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services