You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jl...@apache.org on 2018/11/19 18:56:58 UTC
[1/4] tomee git commit: Fixed typos and grammar
Repository: tomee
Updated Branches:
refs/heads/master 9939dff9f -> 9a0beb701
Fixed typos and grammar
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/ae7607a7
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/ae7607a7
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/ae7607a7
Branch: refs/heads/master
Commit: ae7607a7c7be6be266ca9b7ed2a6dc9fc36ecf6f
Parents: 60ef186
Author: Richard Monson-Haefel <Ri...@Uncommon-Design.com>
Authored: Mon Nov 19 12:09:23 2018 -0600
Committer: Richard Monson-Haefel <Ri...@Uncommon-Design.com>
Committed: Mon Nov 19 12:09:23 2018 -0600
----------------------------------------------------------------------
examples/access-timeout/README.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/ae7607a7/examples/access-timeout/README.md
----------------------------------------------------------------------
diff --git a/examples/access-timeout/README.md b/examples/access-timeout/README.md
index e2b7623..a95f075 100644
--- a/examples/access-timeout/README.md
+++ b/examples/access-timeout/README.md
@@ -39,13 +39,13 @@ The `@AccessTimeout` is simply a convenience wrapper around the `long` and `Time
## Usage
-A method or class can be annotated with @AccessTimeout to specify the maximum time a call might wait for access to the bean wait should a wait condition occur.
+A method or class can be annotated with @AccessTimeout to specify the maximum time a call might wait for access to the bean should a wait condition occur.
The semantics of the value element are as follows:
- A `value` > 0 indicates a timeout value in the units specified by the `unit` element.
- A `value` of 0 means concurrent access is not permitted.
- - A `value` of -1 indicates that the client request will block indefinitely until forward progress it can proceed.
+ - A `value` of -1 indicates that the client request will block indefinitely until forward progress can proceed.
Just as simple as that !
[2/4] tomee git commit: "Fixing some grammar"
Posted by jl...@apache.org.
"Fixing some grammar"
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/a82fdd5d
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/a82fdd5d
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/a82fdd5d
Branch: refs/heads/master
Commit: a82fdd5d10f4d0813cfdcdccc363ce6cf292b292
Parents: ae7607a
Author: Richard Monson-Haefel <Ri...@Uncommon-Design.com>
Authored: Mon Nov 19 12:29:50 2018 -0600
Committer: Richard Monson-Haefel <Ri...@Uncommon-Design.com>
Committed: Mon Nov 19 12:29:50 2018 -0600
----------------------------------------------------------------------
examples/access-timeout-meta/README.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/a82fdd5d/examples/access-timeout-meta/README.md
----------------------------------------------------------------------
diff --git a/examples/access-timeout-meta/README.md b/examples/access-timeout-meta/README.md
index 716efb6..59bdd47 100644
--- a/examples/access-timeout-meta/README.md
+++ b/examples/access-timeout-meta/README.md
@@ -3,7 +3,7 @@ Title: @AccessTimeout the Meta-Annotation Way
Any annotation that takes parameters can benefit from meta-annotations. Here we see how `@AccessTimeout` can be far more understandable and manageable through meta-annotations.
We'll use the [access-timeout](../access-timeout/README.html) example as our use-case.
-The value of the parameters supplied to `@AccessTimeout` have a dramatic affect on how what that annotation actually does. Moreover, `@AccessTimeout` has one of those designs
+The value of the parameters supplied to `@AccessTimeout` have a dramatic affect on what that annotation actually does. Moreover, `@AccessTimeout` has one of those designs
where `-1` and `0` have signifcantly different meanings. One means "wait forever", the other means "never wait". Only a lucky few can remember which is which on a daily basis.
For the rest of us it is a constant source of bugs.
@@ -114,7 +114,7 @@ The simplest approach is to name your meta-annotations after the **configuration
to clearly reflect the contents of each meta-annotation (`@AccessTimeout(-1)` and `@AccessTimeout(0)` respectively).
The **cons** of this approach is that should you want to change the configuration of the application by only changing the meta-annotations -- this is one of the potential benefits
-of meta-annotations. Certainly, the `@AwaitNever` meta-annotation can have no other value than `0` if it is to live up to its name.
+of meta-annotations -- but this may change the meaning of the annotation. Certainly, the `@AwaitNever` meta-annotation can have no other value than `0` if it is to live up to its name.
## Operation names <small>describing the code</small>
@@ -122,7 +122,7 @@ The alternate approach is to name your meta-annotations after the **operations**
`@OrderCheckTimeout` or `@TwitterUpdateTimeout`. These names are configuration-change-proof. They would not change if the configuration changes and in fact they can facilitate
finder-grained control over the configuration of an application.
-The **cons** are of course it is requires far more deliberation and consideration, not to mention more annotations. Your skills as an architect, designer and ability to think as
+The **cons** of this approach is that requires far more deliberation and consideration, not to mention more annotations. Your skills as an architect, designer and ability to think as
a administrator will be challenged. You must be good at wearing your dev-opts hat.
## Pragmatism <small>best of both worlds</small>
Re: [3/4] tomee git commit: Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292
into 60ef186b31702bafbcb2c0ea73f867ce8b419ec6
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Hey Richard,
Thanks for the PR.
I just merged it.
JLouis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Nov 19, 2018 at 7:56 PM <jl...@apache.org> wrote:
> Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into
> 60ef186b31702bafbcb2c0ea73f867ce8b419ec6
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/8efecf9e
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/8efecf9e
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/8efecf9e
>
> Branch: refs/heads/master
> Commit: 8efecf9e35fdfb9f14d8c210d391d9811220d750
> Parents: 60ef186 a82fdd5
> Author: monsonhaefel <ri...@uncommon-design.com>
> Authored: Mon Nov 19 18:48:24 2018 +0000
> Committer: GitHub <no...@github.com>
> Committed: Mon Nov 19 18:48:24 2018 +0000
>
> ----------------------------------------------------------------------
> examples/access-timeout-meta/README.md | 6 +++---
> examples/access-timeout/README.md | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
>
[3/4] tomee git commit: Merge
a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into
60ef186b31702bafbcb2c0ea73f867ce8b419ec6
Posted by jl...@apache.org.
Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into 60ef186b31702bafbcb2c0ea73f867ce8b419ec6
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/8efecf9e
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/8efecf9e
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/8efecf9e
Branch: refs/heads/master
Commit: 8efecf9e35fdfb9f14d8c210d391d9811220d750
Parents: 60ef186 a82fdd5
Author: monsonhaefel <ri...@uncommon-design.com>
Authored: Mon Nov 19 18:48:24 2018 +0000
Committer: GitHub <no...@github.com>
Committed: Mon Nov 19 18:48:24 2018 +0000
----------------------------------------------------------------------
examples/access-timeout-meta/README.md | 6 +++---
examples/access-timeout/README.md | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
[4/4] tomee git commit: Merge remote-tracking branch 'origin/pr/202'
Posted by jl...@apache.org.
Merge remote-tracking branch 'origin/pr/202'
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/9a0beb70
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/9a0beb70
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/9a0beb70
Branch: refs/heads/master
Commit: 9a0beb701f9ff0c6de1c11ae35f70bf082c21e99
Parents: 9939dff 8efecf9
Author: Jean-Louis Monteiro <je...@gmail.com>
Authored: Mon Nov 19 19:56:43 2018 +0100
Committer: Jean-Louis Monteiro <je...@gmail.com>
Committed: Mon Nov 19 19:56:43 2018 +0100
----------------------------------------------------------------------
examples/access-timeout-meta/README.md | 6 +++---
examples/access-timeout/README.md | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------