[GitHub] [beam] AnandInguva commented on a change in pull request #16917: [BEAM-13972] Add RunInference interface

[GitBox <gi...@apache.org>]

AnandInguva commented on a change in pull request #16917:
URL: https://github.com/apache/beam/pull/16917#discussion_r818137359



##########
File path: sdks/python/apache_beam/ml/inference/api_test.py
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import unittest
+from apache_beam.ml.inference.api import PyTorchDevice
+from apache_beam.ml.inference.api import PyTorchModelSpec
+from apache_beam.ml.inference.api import SklearnSerializationType
+from apache_beam.ml.inference.api import SklearnModelSpec
+import pytest  # pylint: disable=unused-import
+
+
+class RunInferenceTest(unittest.TestCase):
+  def test_valid_pytorch_model(self):
+    model = PyTorchModelSpec(
+        model_url='pytorch_model.pth', device=PyTorchDevice.GPU)
+    assert model.model_url == 'pytorch_model.pth'
+    assert model.device == PyTorchDevice.GPU
+
+  def test_invalid_pytorch_model(self):
+    with pytest.raises(TypeError, match='device'):
+      PyTorchModelSpec(model_url='pytorch_model.pth')
+    with pytest.raises(TypeError, match='model_url'):
+      PyTorchModelSpec(device=PyTorchDevice.CPU)
+
+  def test_valid_sklearn_model(self):
+    model = SklearnModelSpec(
+        model_url='sklearn_model.pickle',
+        serialization_type=SklearnSerializationType.PICKLE)
+    assert model.model_url == 'sklearn_model.pickle'

Review comment:
       It was suggested to me to use the class method `self.assertEqual` instead of assert. Making a note here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org