You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/04/16 20:15:24 UTC
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10079
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
IMPALA-6651: [DOCS] Fine grained privileges
Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Cherry-picks: not for 2.x.
---
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
2 files changed, 75 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10079/1
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3:
Has everyone had a chance to review this? Is it ready to be merged?
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 16:35:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3:
> Patch Set 3:
>
> Has everyone had a chance to review this? Is it ready to be merged?
I would like Alex to at least review it.
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 16:39:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 04:19:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@57
PS3, Line 57: <ph id="priv_objs" rev="3.0">object_type ::= TABLE | DATABASE | SERVER | URI</ph>
We should mention somewhere that only ALL applies to the URI object. Finer-grained privileges on a URI are not supported.
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@69
PS3, Line 69: Only administrative users (initially, a predefined set of users
This is not quite true, but let's defer the cleanup. Fredy will file a JIRA for the follow-on task.
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@179
PS3, Line 179: <p>
Also add a note about:
* CREATE TABLE AS SELECT which requires CREATE on the database that should contain the new table and SELECT on the tables references in the query portion of the statement.
* COMPUTE STATS requires ALTER and SELECT on the target table
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml@44
PS3, Line 44: privileges on a specified object from groups. The revocation has a
The last two sentences about revocation having a cascading effect are straight-up wrong. Please remove.
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml@72
PS3, Line 72: union of all other privileges. You cannot revoke <codeph>SELECT</codeph>,
I suggest rephrasing the last sentence to something like this:
Revoking SELECT,INSERT,etc. from a role that only has the ALL privilege has no effect. To reduce the privileges of that role you must REVOKE ALL and GRANT the desired privileges.
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 21:33:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@44
PS1, Line 44: statement grants roles or privileges on specified
: objects to groups.
Should we change the wording of this? We can grant privileges to a role, and we can grant roles to a group, but we cannot grant privileges to a group. This statement seems to indicate we can.
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@118
PS1, Line 118: The <codeph>DROP</codeph> privilege is required to drop a database
: or a table at the <codeph>SERVER</codeph> and
: <codeph>DATABASE</codeph> levels.
This is slightly different than create. DROP at the server level allows you to drop databases and tables. DROP at the database level allows you to drop that specific database and all tables underneath. DROP at the table level allows you to drop that specific table.
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 15:06:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
IMPALA-6651: [DOCS] Fine grained privileges
Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Cherry-picks: not for 2.x.
Reviewed-on: http://gerrit.cloudera.org:8080/10079
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
2 files changed, 165 insertions(+), 41 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Alex Behm, Impala Public Jenkins, Adam Holley,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10079
to look at the new patch set (#4).
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
IMPALA-6651: [DOCS] Fine grained privileges
Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Cherry-picks: not for 2.x.
---
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
2 files changed, 165 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10079/4
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Alex Behm, Impala Public Jenkins, Adam Holley,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10079
to look at the new patch set (#2).
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
IMPALA-6651: [DOCS] Fine grained privileges
Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Cherry-picks: not for 2.x.
---
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
2 files changed, 135 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10079/2
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@105
PS1, Line 105: The <codeph>REFRESH</codeph> privilege is required to execute
It would be much nicer to have all this information presented in a table with 3 columns (privilege, scope, SQL statements).
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@45
PS1, Line 45: specified object from groups. The revocation has a cascading effect. For
I don't know where we want to add this info. Currently we are treating ALL as a distinct privilege. ALL is not a union of all other privileges. In other words, revoking SELECT, INSERT, CREATE, ALTER, etc. on ALL is a no-op.
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@58
PS1, Line 58: privilege ::= ALTER | CREATE | SELECT | SELECT(<varname>column_name</varname>) | INSERT | ALL
Missing REFRESH privilege.
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 16:14:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 2:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@44
PS1, Line 44: statement grants a privilege on a specified object
: to a role or grant
> Should we change the wording of this? We can grant privileges to a role, a
Done
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@105
PS1, Line 105: <stentry>Scope</stentry>
> It would be much nicer to have all this information presented in a table wi
Done
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@118
PS1, Line 118: <stentry><codeph>REFRESH</codeph></stentry>
: <stentry><codeph>DATABASE</codeph></stentry>
: <stentry><codeph>INVALIDATE METADAT
> This is slightly different than create. DROP at the server level allows yo
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@130
PS2, Line 130: <varname>the named table</varname><p><codeph>REFRESH</codeph>
> "on the named table"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@131
PS2, Line 131: <varname>the named table</varname></p></stentry>
> "on the named table"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@137
PS2, Line 137: <varname>all databases</varname><p><codeph>CREATE TABLE</codeph>
> "on all databases"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@138
PS2, Line 138: <varname>all tables</varname></p></stentry>
> "on all tables"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@144
PS2, Line 144: <varname>all tables in the named database</varname></stentry>
> "on all tables in the named database"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@150
PS2, Line 150: <varname>all databases</varname><p><codeph>DROP TABLE</codeph>
> "on all databases"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@151
PS2, Line 151: <varname>all tables</varname></p></stentry>
> "on all tables"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@157
PS2, Line 157: <varname>the named database</varname><p><codeph>DROP TABLE</codeph>
> "on the named database"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@158
PS2, Line 158: <varname>all tables in the named database</varname></p></stentry>
> "on all tables in the named database"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@164
PS2, Line 164: <varname>the named table</varname></stentry>
> "on the named table"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@170
PS2, Line 170: <varname>all tables</varname></stentry>
> "on all tables"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@176
PS2, Line 176: <varname>tables in the named database</varname></stentry>
> "on all tables in the named database"
Done
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@182
PS2, Line 182: <varname>the named table</varname></stentry>
> "on the named table"
Done
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@45
PS1, Line 45: cascading effect. For example, revoking the <codeph>ALL</codeph> privilege
> I don't know where we want to add this info. Currently we are treating ALL
Done
http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@58
PS1, Line 58: privilege ::= ALL | ALTER | CREATE | DROP | INSERT | REFRESH | SELECT | SELECT(<varname>column_name</varname>)
> Missing REFRESH privilege.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 16:17:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/251/
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 04:19:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 04:30:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 2:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@130
PS2, Line 130: <varname>the named table</varname><p><codeph>REFRESH</codeph>
"on the named table"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@131
PS2, Line 131: <varname>the named table</varname></p></stentry>
"on the named table"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@137
PS2, Line 137: <varname>all databases</varname><p><codeph>CREATE TABLE</codeph>
"on all databases"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@138
PS2, Line 138: <varname>all tables</varname></p></stentry>
"on all tables"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@144
PS2, Line 144: <varname>all tables in the named database</varname></stentry>
"on all tables in the named database"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@150
PS2, Line 150: <varname>all databases</varname><p><codeph>DROP TABLE</codeph>
"on all databases"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@151
PS2, Line 151: <varname>all tables</varname></p></stentry>
"on all tables"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@157
PS2, Line 157: <varname>the named database</varname><p><codeph>DROP TABLE</codeph>
"on the named database"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@158
PS2, Line 158: <varname>all tables in the named database</varname></p></stentry>
"on all tables in the named database"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@164
PS2, Line 164: <varname>the named table</varname></stentry>
"on the named table"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@170
PS2, Line 170: <varname>all tables</varname></stentry>
"on all tables"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@176
PS2, Line 176: <varname>tables in the named database</varname></stentry>
"on all tables in the named database"
http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@182
PS2, Line 182: <varname>the named table</varname></stentry>
"on the named table"
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 15:39:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 16:25:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Alex Behm, Impala Public Jenkins, Adam Holley,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10079
to look at the new patch set (#3).
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
IMPALA-6651: [DOCS] Fine grained privileges
Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Cherry-picks: not for 2.x.
---
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
2 files changed, 127 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10079/3
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@57
PS3, Line 57: <ph id="priv_objs" rev="3.0">object_type ::= TABLE | DATABASE | SERVER | URI</ph>
> We should mention somewhere that only ALL applies to the URI object. Finer-
Done
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@69
PS3, Line 69: Only administrative users (initially, a predefined set of users
> This is not quite true, but let's defer the cleanup. Fredy will file a JIRA
Ok
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_grant.xml@179
PS3, Line 179: <p>
> Also add a note about:
Done
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml@44
PS3, Line 44: privileges on a specified object from groups. The revocation has a
> The last two sentences about revocation having a cascading effect are strai
Done
http://gerrit.cloudera.org:8080/#/c/10079/3/docs/topics/impala_revoke.xml@72
PS3, Line 72: union of all other privileges. You cannot revoke <codeph>SELECT</codeph>,
> I suggest rephrasing the last sentence to something like this:
Done
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:06:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges
......................................................................
Patch Set 3:
Reviewed.
--
To view, visit http://gerrit.cloudera.org:8080/10079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab
Gerrit-Change-Number: 10079
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 17:53:11 +0000
Gerrit-HasComments: No