You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/20 05:59:08 UTC
[GitHub] [ozone] smitajoshi12 opened a new pull request, #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
smitajoshi12 opened a new pull request, #3765:
URL: https://github.com/apache/ozone/pull/3765
## What changes were proposed in this pull request?
Display ToolTip to show OM last updated Delta and Full timestamp.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7145
## How was this patch tested?
Manually Tested and reviewed by siyog and corrected review changes suggested by siyog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3765:
URL: https://github.com/apache/ozone/pull/3765#issuecomment-1258759713
Thanks @smitajoshi12 for the patch. Thanks @dombizita for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3765:
URL: https://github.com/apache/ozone/pull/3765#issuecomment-1254909532
@smitajoshi12 Please check your branch and do `git pull` before trying to `git push --force`. Now my previous commit to your branch has been discarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r975894152
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
+ lastUpdatedOMDBDelta: number;
+ lastUpdatedOMDBFull: number;
+ lastUpdatedOMDBDeltaText: string;
+ lastUpdatedOMDBFullText: string;
Review Comment:
We can get rid of the variable here and just use hard-coded text right?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
Review Comment:
Here, we could just use hard-coded text label right? e.g.
```suggestion
Full update: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
<br/>
Delta update: {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976806929
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
Review Comment:
Done Changes as Suggested by You.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976383497
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
Review Comment:
Maybe we could do a small refactoring here, like you changed the text from "updated" to "refreshed" at the already existing timestamp on the page.
```suggestion
lastRefreshed: number;
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
+ </span>
+
+ const lastUpdatedDeltaToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
Review Comment:
This is not necessarily the last updated delta, so we can use the previously used name like this (just so the code can be more understandable later).
```suggestion
const lastUpdatedDeltaFullToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
+ </span>
+
+ const lastUpdatedDeltaToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
+ (
+ <Tooltip
+ placement='bottom' title={omDBDeltaFullToolTip}
+ >
+ {moment(lastUpdatedOMDBDelta).format('LT')}
+ </Tooltip>
+ );
+
+ const lastUpdatedDeltaText = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull===0 || lastUpdatedOMDBFull === undefined ? '' :
Review Comment:
Same here.
```suggestion
const lastUpdatedDeltaFullText = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? '' :
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -75,7 +79,12 @@ export class Overview extends React.Component<Record<string, object>, IOverviewS
buckets: 0,
keys: 0,
missingContainersCount: 0,
- lastUpdated: 0
+ lastUpdated: 0,
Review Comment:
Maybe change here as well to refer that this is the refresh timstamp.
```suggestion
lastRefreshed: 0,
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
Review Comment:
Here as well.
```suggestion
const lastRefreshedText = lastRefreshed === 0 || lastRefreshed === undefined ? 'NA' :
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r975894152
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
+ lastUpdatedOMDBDelta: number;
+ lastUpdatedOMDBFull: number;
+ lastUpdatedOMDBDeltaText: string;
+ lastUpdatedOMDBFullText: string;
Review Comment:
We can get rid of the variable here and just use hard-coded text right? See the comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976869139
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
Review Comment:
Current Timestamp Can be from Full Snapshot or Delta Update so I have used sort method in Descending order so If we do hardcoding of variables this logic will not apply so kept everything in separate variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976805794
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
+ </span>
+
+ const lastUpdatedDeltaToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
+ (
+ <Tooltip
+ placement='bottom' title={omDBDeltaFullToolTip}
+ >
+ {moment(lastUpdatedOMDBDelta).format('LT')}
+ </Tooltip>
+ );
+
+ const lastUpdatedDeltaText = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull===0 || lastUpdatedOMDBFull === undefined ? '' :
Review Comment:
Done Changes as Suggested by You.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
+ </span>
+
+ const lastUpdatedDeltaToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
Review Comment:
Done Changes as Suggested by You.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976868809
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
+ lastUpdatedOMDBDelta: number;
+ lastUpdatedOMDBFull: number;
+ lastUpdatedOMDBDeltaText: string;
+ lastUpdatedOMDBFullText: string;
Review Comment:
Current Timestamp Can be from Full Snapshot or Delta Update so I have used sort method in Descending order so If we do hardcoding of variables this logic will not apply so kept everything in separate variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r977923626
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1218,5 +1218,47 @@
}
],
"sizeDirectKey": 0
- }
-}
+ },
+ "taskStatus": [
+ {
+ "taskName": "ContainerKeyMapperTask",
+ "lastUpdatedTimestamp": 0,
+ "lastUpdatedSeqNumber": 0
+ },
+ {
+ "taskName": "FileSizeCountTask",
+ "lastUpdatedTimestamp": 0,
+ "lastUpdatedSeqNumber": 0
+ },
+ {
+ "taskName": "TableCountTask",
+ "lastUpdatedTimestamp": 0,
+ "lastUpdatedSeqNumber": 0
+ },
+ {
+ "taskName": "NSSummaryTaskWithFSO",
+ "lastUpdatedTimestamp": 0,
+ "lastUpdatedSeqNumber": 0
+ },
+ {
+ "taskName": "OmDeltaRequest",
+ "lastUpdatedTimestamp": 1663842113,
Review Comment:
Please note the timestamp here should be in millis (epoch), not seconds. I have fixed it for you.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -27,6 +27,10 @@ import moment from 'moment';
interface IAutoReloadPanelProps extends RouteComponentProps<object> {
onReload: () => void;
lastUpdated: number;
+ lastUpdatedOMDBDelta: number;
+ lastUpdatedOMDBFull: number;
+ lastUpdatedOMDBDeltaText: string;
+ lastUpdatedOMDBFullText: string;
Review Comment:
I have changes the comparison logic inside the render function. It seems to work as well.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +41,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastRefreshed, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMLatest} = this.props;
+
+ const lastRefreshedRext = lastRefreshed === 0 || lastRefreshed === undefined ? 'NA' :
(
<Tooltip
- placement='bottom' title={moment(lastUpdated).format('ll LTS')}
+ placement='bottom' title={moment(lastRefreshed).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastRefreshed).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {'Delta Update'}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('ll LTS')}
+ <br/>
+ {'Full Update'}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('ll LTS')}
+ </span>
+
+ const lastUpdatedDeltaFullToolTip = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull === 0 || lastUpdatedOMDBFull === undefined ? 'NA' :
+ (
+ <Tooltip
+ placement='bottom' title={omDBDeltaFullToolTip}
+ >
+ {moment(lastUpdatedOMLatest).format('LT')}
+ </Tooltip>
+ );
+
+ const lastUpdatedDeltaFullText = lastUpdatedOMDBDelta === 0 || lastUpdatedOMDBDelta === undefined || lastUpdatedOMDBFull===0 || lastUpdatedOMDBFull === undefined ? '' :
Review Comment:
Whitespace here as well. Fixed it for you.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -75,7 +78,10 @@ export class Overview extends React.Component<Record<string, object>, IOverviewS
buckets: 0,
keys: 0,
missingContainersCount: 0,
- lastUpdated: 0
+ lastRefreshed: 0,
+ lastUpdatedOMDBDelta:0,
+ lastUpdatedOMDBFull:0,
+ lastUpdatedOMLatest:0
Review Comment:
Please note the space after each `:` . To make your code style in-line with the rest. I have fixed this for you this time.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +41,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastRefreshed, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMLatest} = this.props;
+
+ const lastRefreshedRext = lastRefreshed === 0 || lastRefreshed === undefined ? 'NA' :
(
<Tooltip
- placement='bottom' title={moment(lastUpdated).format('ll LTS')}
+ placement='bottom' title={moment(lastRefreshed).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastRefreshed).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {'Delta Update'}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('ll LTS')}
+ <br/>
+ {'Full Update'}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('ll LTS')}
Review Comment:
I have made the change to use `LT` instead of long format so that each line won't be wrapped around in the tooltip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r977456078
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
(
<Tooltip
placement='bottom' title={moment(lastUpdated).format('ll LTS')}
>
- {moment(lastUpdated).format('LTS')}
+ {moment(lastUpdated).format('LT')}
</Tooltip>
);
+
+ const omDBDeltaFullToolTip = <span>
+ {lastUpdatedOMDBFullText}: {moment(lastUpdatedOMDBFull).fromNow()}, {moment(lastUpdatedOMDBFull).format('LT')}
+ <br/>
+ {lastUpdatedOMDBDeltaText}: {moment(lastUpdatedOMDBDelta).fromNow()}, {moment(lastUpdatedOMDBDelta).format('LT')}
Review Comment:
Sorry, I don't understand why we can't hard-code the texts here. If we hard-code here the texts (as we always want to display "`Full update`" or "`Delta update`") we don't even need the `lastUpdatedOMDBDeltaText` and `lastUpdatedOMDBFullText` variables on the `overview.tsx`, as we just add the `autoReloadPanel` to the overview page. We need two parameters for the `autoReloadPanel`, the two timestamps, the delta and full update times. So with the hard-code texts here we can also remove the text variables from the `overview.tsx` which would be easier. Let me know if I misunderstood something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976805572
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -75,7 +79,12 @@ export class Overview extends React.Component<Record<string, object>, IOverviewS
buckets: 0,
keys: 0,
missingContainersCount: 0,
- lastUpdated: 0
+ lastUpdated: 0,
Review Comment:
Done Changes as Suggested by You.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3765:
URL: https://github.com/apache/ozone/pull/3765#issuecomment-1253019580
I have made some UI tweaks around the update time display. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3765:
URL: https://github.com/apache/ozone/pull/3765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3765: HDDS-7145. Recon: Show last OM DB sync time on Overview page
Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3765:
URL: https://github.com/apache/ozone/pull/3765#discussion_r976806437
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -38,21 +42,47 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
};
render() {
- const {onReload, lastUpdated, isLoading} = this.props;
- const lastUpdatedText = lastUpdated === 0 ? 'NA' :
+ const {onReload, lastUpdated, lastUpdatedOMDBDelta,lastUpdatedOMDBFull,isLoading,lastUpdatedOMDBDeltaText,lastUpdatedOMDBFullText} = this.props;
+
+ const lastUpdatedText = lastUpdated === 0 || lastUpdated === undefined ? 'NA' :
Review Comment:
Done Changes as Suggested by You.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org