You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/21 05:14:32 UTC
[GitHub] [apisix] tokers commented on a change in pull request #3379: feat: remove restriction of label pattern to support Chinese
tokers commented on a change in pull request #3379:
URL: https://github.com/apache/apisix/pull/3379#discussion_r561607289
##########
File path: apisix/schema_def.lua
##########
@@ -81,7 +81,6 @@ local remote_addr_def = {
local label_value_def = {
description = "value of label",
type = "string",
- pattern = [[^[a-zA-Z0-9-_.]+$]],
Review comment:
I think whitespaces should still be restricted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org