You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2003/07/12 17:39:33 UTC

mod_speling: ignore dotfiles

the attached patch deals somehow with
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id 284>. It makes it
configurable whether mod_speling should ignore requested dotfiles.

Any opinions would be appreciated.

nd

Re: mod_speling: ignore dotfiles

Posted by André Malo <nd...@perlig.de>.
* Joshua Slive wrote:

> I don't think this warrents a new directive: the current behavior is just
> bad.  But I also don't think it is correct to just give up in this case.
> A very quick look at mod_speling leads me to believe that the problem is
> the stuff inside the #ifdef WANT_BASENAME_MATCH.  I would guess that
> making that conditional on dotloc!=0 would solve the problem.  But I'm
> not in a position to test my theory right now.

It would just change the Checkspelling directive arguments  to
On|Off|WithoutDotfiles.
And would affect the normal spelling adjustment, too, e.g.
/foo would be redirected to /.foo if it exists (or not, if withoutdotfiles).

In the meantime we've had the idea here to grab the IndexIgnore setting from
mod_autoindex instead, which seems to be more reasonable somehow ...?

nd

Re: mod_speling: ignore dotfiles

Posted by Joshua Slive <jo...@slive.ca>.
On Sat, 12 Jul 2003 18:57:04 +0200, "André Malo" <nd...@perlig.de> said:
> * André Malo wrote:
> 
> > the attached patch deals somehow with
> > <http://nagoya.apache.org/bugzilla/show_bug.cgi?id 284>. It makes it
> > configurable whether mod_speling should ignore requested dotfiles.
> 
> Oh dear, the patch was not sufficient. Here comes the full one.
> Anyway, I'm not sure whether this makes sense at all, so any comments are
> welcome :)

I don't think this warrents a new directive: the current behavior is just
bad.  But I also don't think it is correct to just give up in this case. 
A very quick look at mod_speling leads me to believe that the problem is
the stuff inside the #ifdef WANT_BASENAME_MATCH.  I would guess that
making that conditional on dotloc!=0 would solve the problem.  But I'm
not in a position to test my theory right now.

Joshua.
-- 
Joshua Slive
joshua@slive.ca

Re: mod_speling: ignore dotfiles

Posted by André Malo <nd...@perlig.de>.
* André Malo wrote:

> the attached patch deals somehow with
> <http://nagoya.apache.org/bugzilla/show_bug.cgi?id 284>. It makes it
> configurable whether mod_speling should ignore requested dotfiles.

Oh dear, the patch was not sufficient. Here comes the full one.
Anyway, I'm not sure whether this makes sense at all, so any comments are
welcome :)

nd