You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org> on 2005/07/27 21:22:20 UTC
[jira] Created: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
----------------------------------------------------------------------------
Key: GERONIMO-824
URL: http://issues.apache.org/jira/browse/GERONIMO-824
Project: Geronimo
Type: Bug
Components: OpenEJB
Versions: 1.0-M4, 1.0-M5, 1.0, 1.1
Reporter: Matt Hogstrom
org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions.
This fix assigns a type of javax.jms.MessageListener to the interface type as a default.
Index: MdbBuilder.java
===================================================================
RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
retrieving revision 1.21
diff -r1.21 MdbBuilder.java
173c173,179
< builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
---
> String messageInterfaceType = null;
> if (messageDrivenBean.isSetMessagingType()) {
> messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim();
> } else {
> messageInterfaceType = "javax.jms.MessageListener";
> }
> builder.setEndpointInterfaceName(messageInterfaceType);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-824?page=all ]
David Jencks closed GERONIMO-824:
---------------------------------
Fix Version: (was: 1.0-M4)
Resolution: Fixed
Assign To: David Jencks
Should actually be assigned to Matt Hogstrom.
Fixed by patch above applied by matt, rev 1.22
I unified with fix for GERONIMO-780 and fixed a lot of getStringValue().trim() issues, rev 1.23
I think we should consider applying this to M4
> MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-824
> URL: http://issues.apache.org/jira/browse/GERONIMO-824
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Matt Hogstrom
> Assignee: David Jencks
> Fix For: 1.0-M5
>
> org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions.
> This fix assigns a type of javax.jms.MessageListener to the interface type as a default.
> Index: MdbBuilder.java
> ===================================================================
> RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
> retrieving revision 1.21
> diff -r1.21 MdbBuilder.java
> 173c173,179
> < builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
> ---
> > String messageInterfaceType = null;
> > if (messageDrivenBean.isSetMessagingType()) {
> > messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim();
> > } else {
> > messageInterfaceType = "javax.jms.MessageListener";
> > }
> > builder.setEndpointInterfaceName(messageInterfaceType);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-824?page=all ]
David Jencks closed GERONIMO-824:
---------------------------------
Fix Version: 1.0-M4
Resolution: Fixed
m4 fix:
Checking in modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java;
new revision: 1.20.4.2; previous revision: 1.20.4.1
> MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-824
> URL: http://issues.apache.org/jira/browse/GERONIMO-824
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Matt Hogstrom
> Assignee: David Jencks
> Fix For: 1.0-M5, 1.0-M4
>
> org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions.
> This fix assigns a type of javax.jms.MessageListener to the interface type as a default.
> Index: MdbBuilder.java
> ===================================================================
> RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
> retrieving revision 1.21
> diff -r1.21 MdbBuilder.java
> 173c173,179
> < builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
> ---
> > String messageInterfaceType = null;
> > if (messageDrivenBean.isSetMessagingType()) {
> > messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim();
> > } else {
> > messageInterfaceType = "javax.jms.MessageListener";
> > }
> > builder.setEndpointInterfaceName(messageInterfaceType);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-824?page=all ]
Aaron Mulder updated GERONIMO-824:
----------------------------------
Fix Version: 1.0-M4
1.0-M5
Version: 1.0-M3
(was: 1.0-M4)
(was: 1.0-M5)
(was: 1.0)
(was: 1.1)
Please don't mark a bug as affecting versions that haven't been released yet. To get on the road map, they need to be marked with a Fix Version of the versions that haven't been released yet.
> MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-824
> URL: http://issues.apache.org/jira/browse/GERONIMO-824
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Matt Hogstrom
> Fix For: 1.0-M4, 1.0-M5
>
> org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions.
> This fix assigns a type of javax.jms.MessageListener to the interface type as a default.
> Index: MdbBuilder.java
> ===================================================================
> RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
> retrieving revision 1.21
> diff -r1.21 MdbBuilder.java
> 173c173,179
> < builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
> ---
> > String messageInterfaceType = null;
> > if (messageDrivenBean.isSetMessagingType()) {
> > messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim();
> > } else {
> > messageInterfaceType = "javax.jms.MessageListener";
> > }
> > builder.setEndpointInterfaceName(messageInterfaceType);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-824?page=all ]
David Jencks reopened GERONIMO-824:
-----------------------------------
Needs to go into M4 as well.
> MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-824
> URL: http://issues.apache.org/jira/browse/GERONIMO-824
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Matt Hogstrom
> Assignee: David Jencks
> Fix For: 1.0-M5
>
> org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions.
> This fix assigns a type of javax.jms.MessageListener to the interface type as a default.
> Index: MdbBuilder.java
> ===================================================================
> RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
> retrieving revision 1.21
> diff -r1.21 MdbBuilder.java
> 173c173,179
> < builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
> ---
> > String messageInterfaceType = null;
> > if (messageDrivenBean.isSetMessagingType()) {
> > messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim();
> > } else {
> > messageInterfaceType = "javax.jms.MessageListener";
> > }
> > builder.setEndpointInterfaceName(messageInterfaceType);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira