You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/06 17:42:42 UTC

[GitHub] [helix] mgao0 commented on pull request #2017: Fix TestCloudEventCallbackProperty by bypassing connecting to zk

mgao0 commented on PR #2017:
URL: https://github.com/apache/helix/pull/2017#issuecomment-1090548542

   This PR is ready to be merged. Approved by @narendly , thanks!
   
   Commit message:
   Due to logical change in ZKHelixManager constructor in a https://github.com/apache/helix/pull/1986, TestCloudEventCallbackProperty broke because in this test it doesn't connect to zookeeper server.
   To fix this test, we separated MockCloudEventAwareHelixManager （previously called MockEventAwareZKHelixManager, nested inside TestCloudEventCallbackProperty）into a class, and include all and only the logics related to cloud events in MockCloudEventAwareHelixManager. More detailed, we mock a cloud config object retrieved from zk to bypass connection to zk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org