You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/12/11 14:09:05 UTC

[GitHub] QiuMM edited a comment on issue #6336: update insert pending segments logic to synchronous

QiuMM edited a comment on issue #6336: update insert pending segments logic to synchronous
URL: https://github.com/apache/incubator-druid/pull/6336#issuecomment-446211138
 
 
   @FaxianZhao @jihoonson I think this PR should be reverted, after merged this PR, it takes very long time to open the overlord console. In my scenario, there are 1200 peon tasks and we use mysql as the metastore. In this PR, use `TaskLockbox#doInCriticalSection` to perform allocating pending segments which seems would block other things. After revert this, my overlord works fine again.
   
   ![lark20181211-215648](https://user-images.githubusercontent.com/15156517/49805286-bd20e380-fd8f-11e8-9c9e-4d44d2cf7b18.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org