You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/29 17:46:58 UTC

[GitHub] [spark] warrenzhu25 opened a new pull request, #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

warrenzhu25 opened a new pull request, #36717:
URL: https://github.com/apache/spark/pull/36717

   What changes were proposed in this pull request?
   Add check for total executor cores when SetReaderPartitions message received.
   
   Why are the changes needed?
   In continuous processing mode, EpochCoordinator won't add offsets to query until got ReportPartitionOffset from all partitions. Normally, each kafka topic partition will be handled by one core, if total cores is smaller than total kafka topic partition counts, the job will hang without any error message.
   
   Does this PR introduce any user-facing change?
   Yes, if total executor cores is smaller than total kafka partition count, the exception with below error will be thrown:
   `
   Total $numReaderPartitions (kafka partitions) * $cpusPerTask (cpus per task) =
   $neededCores needed,
   but only have min($numExecutors (executors) * $coresPerExecutor (cores per executor) =
   $totalRequestedCores, spark.cores.max = $maxCores) = $totalAvailableCores (total cores).
   Please increase total number of executor cores to at least $neededCores.
   `
   How was this patch tested?
   Added test in EpochCoordinatorSuite


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36717:
URL: https://github.com/apache/spark/pull/36717#issuecomment-1141366666

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] warrenzhu25 commented on pull request #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

Posted by GitBox <gi...@apache.org>.
warrenzhu25 commented on PR #36717:
URL: https://github.com/apache/spark/pull/36717#issuecomment-1277016414

   @Ngone51 @viirya @HeartSaVioR @xuanyuanking @gaborgsomogyi Could you help take a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] warrenzhu25 commented on pull request #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

Posted by GitBox <gi...@apache.org>.
warrenzhu25 commented on PR #36717:
URL: https://github.com/apache/spark/pull/36717#issuecomment-1243188245

   @Ngone51 @viirya @HeartSaVioR @xuanyuanking @gaborgsomogyi Could you help take a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] tardunge commented on pull request #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

Posted by GitBox <gi...@apache.org>.
tardunge commented on PR #36717:
URL: https://github.com/apache/spark/pull/36717#issuecomment-1170267023

   sorry, didn't mean to approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] warrenzhu25 commented on pull request #36717: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition

Posted by GitBox <gi...@apache.org>.
warrenzhu25 commented on PR #36717:
URL: https://github.com/apache/spark/pull/36717#issuecomment-1231035612

   @HeartSaVioR @xuanyuanking @gaborgsomogyi @viirya Could you help take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org