You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@yandex-team.ru> on 2017/09/20 17:05:05 UTC

Review Request 62444: Add UNREACHABLE() macro to __cxa_pure_virtual.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62444/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

The function __cxa_pure_virtual must not return,
but newer versions of clang detect that the expansion
of the RAW_LOG() macro contains returning code paths
for arguments other than FATAL.


Diffs
-----

  src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 


Diff: https://reviews.apache.org/r/62444/diff/1/


Testing
-------


Thanks,

Benno Evers