You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by limited <gi...@git.apache.org> on 2016/11/01 03:30:41 UTC
[GitHub] incubator-trafficcontrol pull request #30: Add --skip-ssl option to post ins...
GitHub user limited opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/30
Add --skip-ssl option to post install to skip auto generation of SSL \u2026
\u2026certificate
This fixes https://github.com/Comcast/traffic_control/issues/1179
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/limited/incubator-trafficcontrol skipssl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 4339b3f73aa08aa1ed5049ae2b14e0d82dd759e9
Author: Eric Friedrich <ef...@cisco.com>
Date: 2016-11-01T03:26:28Z
Add --skip-ssl option to post install to skip auto generation of SSL certificate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #30: Add --skip-ssl option to post ins...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/30#discussion_r86021333
--- Diff: traffic_ops/install/bin/postinstall ---
@@ -48,6 +49,10 @@ my $tmAdminUser = "";
my $tmAdminPw = "";
my $parameters;
+my $skip_ssl = 0;
+GetOptions("skip-ssl" => \$skip_ssl)
+or die ("Error in command line arguments");
+
--- End diff --
indentation issues both here and below.. perltidy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #30: Add --skip-ssl option to post ins...
Posted by limited <gi...@git.apache.org>.
Github user limited closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
I'll fix, need a day or so
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #30: Add --skip-ssl option to post ins...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/30#discussion_r86022377
--- Diff: traffic_ops/install/bin/postinstall ---
@@ -48,6 +49,10 @@ my $tmAdminUser = "";
my $tmAdminPw = "";
my $parameters;
+my $skip_ssl = 0;
+GetOptions("skip-ssl" => \$skip_ssl)
--- End diff --
how about adding a --help? No way to tell what the option is without looking thru the source..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
I think this should be closed -- postinstall now has `-defaults` option to write out a cfg file with all default questions/answers. And `-a -cfile=<file>` to load all from the file with no user input.
To skip cert generation, change this answer to `"no"`:
```
"/opt/traffic_ops/install/data/json/openssl_configuration.json" : [
{
"Do you want to generate a certificate?" : "yes",
"config_var" : "genCert"
},
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
@limited I think this can be closed per @dangogh's comment above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
perltidy went crazy on me here- any suggestions on how to adjust @dangogh ? I copy and pasted the lines as is from the traffic-control-cdn developers page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
Not yet, but Peter suggested adding a question to the input in 126 to allow a user to skip it. I would support that approach over this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
@limited this should be covered by #126, don't you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---