Re: [PR] SOLR-17742 [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2173353097


##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -363,7 +363,7 @@ private SolrConfig(SolrResourceLoader loader, String name, Properties substituta
         log.warn("Ignored deprecated enableStreamBody in config; use sys-prop");
       }
 
-      handleSelect = get("requestDispatcher").boolAttr("handleSelect", false);
+      // handleSelect = get("requestDispatcher").boolAttr("handleSelect", false);

Review Comment:
   again



##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -128,7 +128,7 @@ public enum PluginOpts {
 
   private int formUploadLimitKB;
 
-  private boolean handleSelect;
+  // private boolean handleSelect;

Review Comment:
   remove this outright; don't leave commented



##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -1010,7 +1007,7 @@ public Map<String, Object> toMap(Map<String, Object> result) {
         m, filterCacheConfig, queryResultCacheConfig, documentCacheConfig, fieldValueCacheConfig);
     m = new LinkedHashMap<>();
     result.put("requestDispatcher", m);
-    m.put("handleSelect", handleSelect);
+    // m.put("handleSelect", handleSelect);

Review Comment:
   again



##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -959,10 +959,7 @@ public int getFormUploadLimitKB() {
     return formUploadLimitKB;
   }
 
-  public boolean isHandleSelect() {
-    return handleSelect;
-  }
-
+  /** public boolean isHandleSelect() { return handleSelect; } */

Review Comment:
   uh?



##########
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##########
@@ -454,25 +453,18 @@ protected void extractHandlerFromURLPath(SolrRequestParsers parser) throws Excep
     if (handler == null && path.length() > 1) { // don't match "" or "/" as valid path
       handler = core.getRequestHandler(path);
       // no handler yet but <requestDispatcher> allows us to handle /select with a 'qt' param

Review Comment:
   and this comment is now obsolete/false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org