[GitHub] [apisix] bisakhmondal commented on issue #6112: Proposal: Develop Loggly logging plugin

[GitBox <gi...@apache.org>]

bisakhmondal commented on issue #6112:
URL: https://github.com/apache/apisix/issues/6112#issuecomment-1013431334


   > I think we can remove `include_req_body` & `tags`? Instead, we can use `log_util.get_full_log` & `log_util.get_custom_format_log`. The `tags` field can be implemented via `get_custom_format_log`.
   
   Hey, thanks for the nice suggestions. I looked into the http_logger implementation of custom_log_format definition in the plugin metadata. The default log format looks very minimal, I don't think it's suitable for logging. I think we can do one thing:
   
   - Make this a field inside the plugin schema because tags must be configured route-specific instead of making it apisix specific.
   - If log_format == empty ; dump `get_full_log` else generate `get_custom_format_log`
   
   But one thing, even with tags shifted to the log format, we are going to expect the log format object something like
   {
   "host": "$host",
   ....
   **"tags": ["route-critical"]**
   }
   Because we have to extract it from the generated log_format body and use it inside Syslog header generation.
   So I think we are just making things convoluted, isn't it? WDYT. Just share some thoughts here. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org