[GitHub] [hadoop] bshashikant commented on a change in pull request #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul Kumar Singh.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul Kumar Singh.
URL: https://github.com/apache/hadoop/pull/1281#discussion_r313302193
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamWithFailures.java
 ##########
 @@ -501,14 +501,14 @@ public void test2DatanodesFailure() throws Exception {
     // and one flush for partial chunk
     key.flush();
 
+    Throwable ioException = HddsClientUtils.checkForException(
+        blockOutputStream.getIoException());
     // Since, 2 datanodes went down, if the pipeline gets destroyed quickly,
     // it will hit GroupMismatchException else, it will fail with
     // RaftRetryFailureException
 
 Review comment:
   Please update the comment stating it can also fail with container not open exception in case the containers got closed quickly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org