You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bilgin Ibryam (JIRA)" <ji...@apache.org> on 2007/07/17 18:43:04 UTC
[jira] Created: (OFBIZ-1154) Black list is not working
Black list is not working
-------------------------
Key: OFBIZ-1154
URL: https://issues.apache.org/jira/browse/OFBIZ-1154
Project: OFBiz
Issue Type: Bug
Components: ecommerce, order
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk, Release Branch 4.0
Hi guys,
I want to ask what is the purpose of Black list in ofbiz and how should it really work?
I tried to use it and found that it is not working at all.
1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
Regards,
Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1154) Black list is not working
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1154:
---------------------------------
Attachment: blacklist.patch
this patch fixes point 1 and some part of point 2
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1154) Black list is not working
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-1154:
----------------------------------------
Assignee: Bilgin Ibryam (was: Jacopo Cappellato)
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1154) Black list is not working
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-1154:
----------------------------------------
Assignee: Jacopo Cappellato
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1154) Black list is not working
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553573 ]
Jacques Le Roux commented on OFBIZ-1154:
----------------------------------------
Hi Bilgin,
You are now able to commit it ;o) Maybe your question could have more impact on dev ML ?
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1154) Black list is not working
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1154:
---------------------------------
Fix Version/s: Release Branch 4.0
Committed in 4.0 rev. 612793
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1154) Black list is not working
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554340 ]
Bilgin Ibryam commented on OFBIZ-1154:
--------------------------------------
Hi Jacques, Thanks for the reminder.
I will take care of it, very soon!
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1154) Black list is not working
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam closed OFBIZ-1154.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: Release Branch 4.0)
After a small discussion in dev list, i committed a modified patch in trunk r612767 that fixes the bugs described in point 1 and 2 (and even one more bug caused when using anonymous user login)
About point 3 there should be another improvement issue.
> Black list is not working
> -------------------------
>
> Key: OFBIZ-1154
> URL: https://issues.apache.org/jira/browse/OFBIZ-1154
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: blacklist.patch
>
>
> Hi guys,
> I want to ask what is the purpose of Black list in ofbiz and how should it really work?
> I tried to use it and found that it is not working at all.
> 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.
> 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
> In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?
> 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.
> 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.