[GitHub] [pulsar] Jason918 commented on a change in pull request #14804: [Issue 14505] PIP-145: Enable evaluating subscription pattern on broker side

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #14804:
URL: https://github.com/apache/pulsar/pull/14804#discussion_r840182914



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1968,12 +1978,26 @@ protected void handleGetTopicsOfNamespace(CommandGetTopicsOfNamespace commandGet
                 if (isAuthorized) {
                     getBrokerService().pulsar().getNamespaceService().getListOfTopics(namespaceName, mode)
                         .thenAccept(topics -> {
+                            boolean filterTopics = enableSubscriptionPatternEvaluation && topicsPattern.isPresent()
+                                    && topicsPattern.get().length() <= maxSubscriptionPatternLength;

Review comment:
       > From a user perspective there would be no visible difference.
   
   The user here is more like cluster maintainer who have access to broker config to enable this feature.
   
   
   
   > The point is to avoid "unbound" regexes on server side.
   
   Yes, this limitation is reasonable. But I think we need a warn log here for cluster maintainer, as they may not know exactly how long the topic pattern string is used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org