[GitHub] [doris] dataroaring commented on a diff in pull request #15749: [improvement](reader) use union merge when rowset are noneoverlapping

[GitBox <gi...@apache.org>]

dataroaring commented on code in PR #15749:
URL: https://github.com/apache/doris/pull/15749#discussion_r1067647363


##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -129,6 +132,19 @@ Status VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_reade
                     new Level1Iterator(_children, _reader, _merge, _is_reverse, _skip_same));
         }
     } else {
+        bool have_multiple_child = false;
+        bool is_first_child = true;
+        for (auto iter = _children.begin(); iter != _children.end();) {
+            auto s = (*iter)->init_for_union(is_first_child, have_multiple_child);
+            if (!s.ok()) {
+                delete (*iter);
+                iter = _children.erase(iter);
+            } else {

Review Comment:
   Should we return the status here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org