You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/14 22:28:50 UTC
Re: Review Request 40268: Libprocess Reinit: Change
Socket::DEFAULT_KIND to a non-static value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40268/
-----------------------------------------------------------
(Updated April 14, 2016, 1:28 p.m.)
Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
Changes
-------
Reviving this chain...
Summary (updated)
-----------------
Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.
Bugs: MESOS-3820
https://issues.apache.org/jira/browse/MESOS-3820
Repository: mesos
Description (updated)
-------
This is needed for tests that utilize the test-only
`process::reinitialize` function.
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp 4cb49680d1304899a4ee675ac07379e51d9c55b1
3rdparty/libprocess/src/socket.cpp ec0e913aca30f92d4a0543ad1e685b897617bca3
Diff: https://reviews.apache.org/r/40268/diff/
Testing
-------
Some test cleanup issues were uncovered by this change; fixed here: https://reviews.apache.org/r/40453/
Thanks,
Joseph Wu