[GitHub] spark pull request #20576: [SPARK-23389][CORE]When the shuffle dependency sp...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20576#discussion_r171278411
  
    --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala ---
    @@ -188,9 +188,8 @@ private[spark] object SortShuffleManager extends Logging {
           log.debug(s"Can't use serialized shuffle for shuffle $shufId because the serializer, " +
             s"${dependency.serializer.getClass.getName}, does not support object relocation")
           false
    -    } else if (dependency.aggregator.isDefined) {
    -      log.debug(
    -        s"Can't use serialized shuffle for shuffle $shufId because an aggregator is defined")
    --- End diff --
    
    can we keep the log with a little update?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org