You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/21 17:07:14 UTC
[GitHub] [httpcomponents-core] malaysf opened a new pull request #204: HTTPCORE-638: SharedOutputBuffer must only call dataStreamChannel.endStream() once
malaysf opened a new pull request #204:
URL: https://github.com/apache/httpcomponents-core/pull/204
It is possible for `flush` to be called after `markCompleted` and both would call `dataStreamChannel.endStream` which is incorrect, `endStream` must only be called once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #204: HTTPCORE-638: SharedOutputBuffer must only call dataStreamChannel.endStream() once
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #204:
URL: https://github.com/apache/httpcomponents-core/pull/204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] malaysf commented on a change in pull request #204: HTTPCORE-638: SharedOutputBuffer must only call dataStreamChannel.endStream() once
Posted by GitBox <gi...@apache.org>.
malaysf commented on a change in pull request #204:
URL: https://github.com/apache/httpcomponents-core/pull/204#discussion_r458859543
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/classic/SharedOutputBuffer.java
##########
@@ -162,4 +164,11 @@ private void waitFlush() throws InterruptedIOException {
setInputMode();
}
+ private void propagateEndStreamOnce() throws IOException {
Review comment:
Sure, I'll make the change shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #204: HTTPCORE-638: SharedOutputBuffer must only call dataStreamChannel.endStream() once
Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #204:
URL: https://github.com/apache/httpcomponents-core/pull/204#discussion_r458646992
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/classic/SharedOutputBuffer.java
##########
@@ -162,4 +164,11 @@ private void waitFlush() throws InterruptedIOException {
setInputMode();
}
+ private void propagateEndStreamOnce() throws IOException {
Review comment:
@malaysf One really minor thing. I suppose just `propagateEndStream` as the method name should be clear enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org