You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pdxcodemonkey (GitHub)" <gi...@apache.org> on 2019/09/20 17:31:16 UTC

[GitHub] [geode-native] pdxcodemonkey opened pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts


[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on issue #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by lg...@gitbox.apache.org.
This pull request **fixes 15 alerts** when merging d7a46a0927f1ef4bc4e853635bb48ce88ceaede0 into 05710df47b886b831b4ee49b68faf971a1205a0e - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-1f637e923adabe38325b0b2c2c3d6b808af6e1dc)

**fixed alerts:**

* 9 for Wrong type of arguments to formatting function
* 2 for Possible loss of precision
* 2 for Useless assignment to local variable
* 1 for Container contents are never accessed
* 1 for Potentially overflowing call to snprintf

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by "moleske (GitHub)" <gi...@apache.org>.
Was totally just fixing complaints, didn't actually look at the substance 😞 

Apparently we are never actually using the list the to stop individual servers, that should probably be the real fix instead of just deleting the list.

For record keeping, LGTM was pointing out that we added to the list of servers, but never actually retrieved any information from that list later.

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on issue #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by lg...@gitbox.apache.org.
This pull request **fixes 13 alerts** when merging f7e6eeb40eb2fc85a3d788b79aea3c1a722c3bf9 into b4c688df4c3fa34e7170cd58266afb93e0970f11 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-bff0339ed783854dc56767df6855c2ecb83f7f16)

**fixed alerts:**

* 9 for Wrong type of arguments to formatting function
* 2 for Useless assignment to local variable
* 1 for Container contents are never accessed
* 1 for Potentially overflowing call to snprintf

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on issue #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by lg...@gitbox.apache.org.
This pull request **fixes 15 alerts** when merging feb77e45f430b905837e87d393500da40b538134 into 98520276ecf1ce5551c4c655b9ac8f686fd8695f - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-2c666192e54a8a7be2330949e26aa97f76bfe6a8)

**fixed alerts:**

* 9 for Wrong type of arguments to formatting function
* 2 for Possible loss of precision
* 2 for Useless assignment to local variable
* 1 for Container contents are never accessed
* 1 for Potentially overflowing call to snprintf

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] steve-sienk commented on pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by "steve-sienk (GitHub)" <gi...@apache.org>.
LGTM: This didn't actually get fixed, ShareQuantity is a double.

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Why remove the servers set? They are going to be needed to stop individual servers.

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on issue #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by lg...@gitbox.apache.org.
This pull request **introduces 1 alert** and **fixes 15** when merging c363145ef629482f90f03a4151bc5c097be61f04 into 98520276ecf1ce5551c4c655b9ac8f686fd8695f - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-890923ef9161286ea925e0712e2a575ad174917b)

**new alerts:**

* 1 for Possible loss of precision

**fixed alerts:**

* 9 for Wrong type of arguments to formatting function
* 2 for Possible loss of precision
* 2 for Useless assignment to local variable
* 1 for Container contents are never accessed
* 1 for Potentially overflowing call to snprintf

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #526: GEODE-7207: Fix remaining LGTM "Error" level alerts

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Nice!!

[ Full content available at: https://github.com/apache/geode-native/pull/526 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org