You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/08 18:02:29 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3804: Add unary_dict_mut

alamb commented on code in PR #3804:
URL: https://github.com/apache/arrow-rs/pull/3804#discussion_r1129845208


##########
arrow-arith/src/arity.rs:
##########
@@ -105,6 +105,20 @@ where
     Ok(Arc::new(array.with_values(&values)))
 }
 
+/// See [`DictionaryArray::unary_mut`]

Review Comment:
   Is the idea that @Ted-Jiang  will use this as part of https://github.com/apache/arrow-rs/pull/3709 ?
   
   I think it is fine to include for some future use, but it might be better to simply include this function when there was a specific use of it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org