[arrow] branch master updated: GH-33666: [R] Remove extraneous argument to semi_join (#33693)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new fa590511cc GH-33666: [R] Remove extraneous argument to semi_join (#33693)
fa590511cc is described below

commit fa590511ccd2310b01c6d4040f6c4a83010743a4
Author: Nic Crane <th...@gmail.com>
AuthorDate: Tue Jan 17 02:45:57 2023 +0000

    GH-33666: [R] Remove extraneous argument to semi_join (#33693)
    
    This PR removes the `keep` argument from the test for `semi_join()`, which are causing the unit tests to fail.  It also removes the argument `suffix` argument (which is not part of the dplyr function signature) from the function signature here.
    
    Closes: #33666
    
    Authored-by: Nic Crane <th...@gmail.com>
    Signed-off-by: Dewey Dunnington <de...@fishandwhistle.net>
---
 r/tests/testthat/test-dplyr-join.R | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/r/tests/testthat/test-dplyr-join.R b/r/tests/testthat/test-dplyr-join.R
index 3470a886b3..2520d561cf 100644
--- a/r/tests/testthat/test-dplyr-join.R
+++ b/r/tests/testthat/test-dplyr-join.R
@@ -82,7 +82,7 @@ test_that("left_join with join_by", {
       left_join(
         to_join %>%
           rename(the_grouping = some_grouping),
-          join_by(some_grouping == the_grouping)
+        join_by(some_grouping == the_grouping)
       ) %>%
       collect(),
     left
@@ -240,14 +240,7 @@ test_that("full_join", {
 test_that("semi_join", {
   compare_dplyr_binding(
     .input %>%
-      semi_join(to_join, by = "some_grouping", keep = TRUE) %>%
-      collect(),
-    left
-  )
-
-  compare_dplyr_binding(
-    .input %>%
-      semi_join(to_join, by = "some_grouping", keep = FALSE) %>%
+      semi_join(to_join, by = "some_grouping") %>%
       collect(),
     left
   )