You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/04/23 21:22:50 UTC
[jira] Created: (POOL-167) ObjectTimestampPair - fields tstamp and
value "deprecation"
ObjectTimestampPair - fields tstamp and value "deprecation"
-----------------------------------------------------------
Key: POOL-167
URL: https://issues.apache.org/jira/browse/POOL-167
Project: Commons Pool
Issue Type: Bug
Affects Versions: 1.5.4
Reporter: Sebb
Priority: Minor
ObjectTimestampPair - fields tstamp and value are marked deprecated:
"this field will be made private and final in version 2.0"
Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
One way round this would be to add package-protected getter methods for the fields.
This would allow the current code to be updated to avoid the deprecations.
Does that seem like a sensible approach?
If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (POOL-167) ObjectTimestampPair - fields tstamp and
value "deprecation"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated POOL-167:
-----------------------------
Fix Version/s: 1.5.5
Affects Version/s: Nightly Builds
(was: 1.5.4)
> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
> Key: POOL-167
> URL: https://issues.apache.org/jira/browse/POOL-167
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: Nightly Builds
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.5.5
>
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (POOL-167) ObjectTimestampPair - fields tstamp
and value "deprecation"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860533#action_12860533 ]
Phil Steitz commented on POOL-167:
----------------------------------
What I meant in the deprecation comment was that *direct* access to the fields would no longer be possible in 2.0 - i.e., they will be private. I am OK with edits to the comment making that clearer.
> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
> Key: POOL-167
> URL: https://issues.apache.org/jira/browse/POOL-167
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.5.4
> Reporter: Sebb
> Priority: Minor
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (POOL-167) ObjectTimestampPair - fields tstamp and
value "deprecation"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz resolved POOL-167.
------------------------------
Resolution: Fixed
Getters added in r990683.
> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
> Key: POOL-167
> URL: https://issues.apache.org/jira/browse/POOL-167
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: Nightly Builds
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.5.5
>
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (POOL-167) ObjectTimestampPair - fields tstamp
and value "deprecation"
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860542#action_12860542 ]
Sebb commented on POOL-167:
---------------------------
So is the plan to add getters for 2.0?
If so, then it would be sensible to add them now, so that migration can start.
> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
> Key: POOL-167
> URL: https://issues.apache.org/jira/browse/POOL-167
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.5.4
> Reporter: Sebb
> Priority: Minor
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (POOL-167) ObjectTimestampPair - fields tstamp
and value "deprecation"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860549#action_12860549 ]
Phil Steitz commented on POOL-167:
----------------------------------
Yes, we will need to add getters, assuming we keep this class. Another thing to think about for 2.0 is the visibility of ObjectTimeStampPair itself. Might be better to pull it out of GKOP, since it is also used by GOP and could be useful for other impls. Given this and other basic questions that we will need to answer for 2.0, I don't know if it makes sense at this point to add the getters and migrate the 1.x code to use them.
> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
> Key: POOL-167
> URL: https://issues.apache.org/jira/browse/POOL-167
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.5.4
> Reporter: Sebb
> Priority: Minor
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.