You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/11 10:26:00 UTC

[GitHub] [flink] kl0u commented on a change in pull request #10496: [FLINK-15153]Service selector needs to contain jobmanager component label

kl0u commented on a change in pull request #10496: [FLINK-15153]Service selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r356514915
 
 

 ##########
 File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesCliOptions.java
 ##########
 @@ -91,22 +90,6 @@ public static Option getOptionWithPrefix(Option option, String shortPrefix, Stri
 		.desc("Help for Kubernetes session CLI.")
 		.build();
 
 
 Review comment:
   Removing these two means that the `KubernetesConfigOptionsInternal.ENTRY_POINT_CLASS_ARGS` is always null so we can remove it, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services