You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/14 11:21:34 UTC
[GitHub] [hive] deniskuzZ opened a new pull request #2277: Avoid piling up compaction_queue entries in 'ready for cleaning' state
deniskuzZ opened a new pull request #2277:
URL: https://github.com/apache/hive/pull/2277
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672959780
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
Yes, ci.highestWriteId = the highest write id that was compacted.
So if we have this after compaction:
delta_1_1
delta_2_2
delta_3_3
base_3
ci.highestWriteId=3, so the cleaner will remove (assuming MIN_HISTORY_LEVEL is still being used) :
delta_1_1
delta_2_2
delta_3_3
But how do we know those can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672892362
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
How do we know that ci.highestWriteId's txn <= the min open txn the cleaner uses, if MIN_HISTORY_LEVEL is still used?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
Yes, ci.highestWriteId = the highest write id that was compacted.
So if we have this after compaction:
delta_1_1
delta_2_2
delta_3_3
base_3
ci.highestWriteId=3, so the cleaner will remove (assuming MIN_HISTORY_LEVEL is still being used) :
delta_1_1
delta_2_2
delta_3_3
But how do we know those can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2277: Avoid piling up compaction_queue entries in 'ready for cleaning' state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2277:
URL: https://github.com/apache/hive/pull/2277#issuecomment-879483819
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672900959
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records all open txns that have to be ignored.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records writeid hwm and all open txns below it that have to be ignored.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
validWriteIdList besides the updated hwm has also an exceptions list, that would show if there are any open txns in that range. What we are doing here is just lowering the hwm so that cleaner won't remove more than this compaction was responsible for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r676430685
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
And we're 100% sure that we're lowering it and not raising it? Maybe we could include some sort of assertion that ci.highestWriteId <= previous high watermark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672900959
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records all open txns that have to be ignored.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records writeid hwm and all open txns below it that have to be ignored.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
validWriteIdList besides the updated hwm has also an exceptions list, that would show if there are any open txns in that range. What we are doing here is just lowering the hwm so that cleaner won't remove more than this compaction was responsible for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ merged pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ merged pull request #2277:
URL: https://github.com/apache/hive/pull/2277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r677247101
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
sure, that could be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672892362
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
How do we know that ci.highestWriteId's txn <= the min open txn the cleaner uses, if MIN_HISTORY_LEVEL is still used?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
Yes, ci.highestWriteId = the highest write id that was compacted.
So if we have this after compaction:
delta_1_1
delta_2_2
delta_3_3
base_3
ci.highestWriteId=3, so the cleaner will remove (assuming MIN_HISTORY_LEVEL is still being used) :
delta_1_1
delta_2_2
delta_3_3
But how do we know those can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672900959
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records all open txns that have to be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672900959
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
not sure I got the question. but highestWriteId is recorded at the time when the compaction txn starts, so it records writeid hwm and all open txns below it that have to be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672892362
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
How do we know that ci.highestWriteId's txn <= the min open txn the cleaner uses, if MIN_HISTORY_LEVEL is still used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org