[GitHub] rdhabalia opened a new pull request #725: Validate dynamic-configuration value while updating or init

[gi...@git.apache.org]

rdhabalia opened a new pull request #725: Validate dynamic-configuration value while updating or init
URL: https://github.com/apache/incubator-pulsar/pull/725
 
 
   ### Motivation
   
   - Right now, broker doesn't validate dynamic-configuration value before updating it to zookeeper. So, user may update configuration with typo. 
   - also, broker should validate dynamic-config value while starting in order to avoid picking up invalid value.
   eg: if someone has dynamic-config present for `loadManagerClassName` in old release and release-1.19 has changed the className then broker startup should notify invalid config value.
   
   ### Modifications
   
   - Do dynamic-config validation before updating it 
   - Validate dynamic-config value on broker startup
   Right now, we just have validation on `loadManagerClassName` configuration.
   
   ### Result
   
   - broker will not allow update of invalid dynamic-config
   - broker startup will fail if it finds out invalid dynamic config.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services