You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/03/11 23:36:37 UTC

Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44736/
-----------------------------------------------------------

Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.


Repository: geode


Description
-------

added an assertion that the distributed system hasn't changed in between getSystem() and createRegion() calls.


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java a8ea590c96334d622e1b96057f62fe4414224f13 

Diff: https://reviews.apache.org/r/44736/diff/


Testing
-------


Thanks,

Bruce Schuchardt

Re: Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44736/#review123225
-----------------------------------------------------------


Ship it!




Ship It!

- Jianxia Chen


On March 11, 2016, 10:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44736/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> added an assertion that the distributed system hasn't changed in between getSystem() and createRegion() calls.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java a8ea590c96334d622e1b96057f62fe4414224f13 
> 
> Diff: https://reviews.apache.org/r/44736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

Posted by Bruce Schuchardt <bs...@pivotal.io>.

> On March 13, 2016, 8:17 p.m., Udo Kohlmeyer wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java, line 172
> > <https://reviews.apache.org/r/44736/diff/1/?file=1296443#file1296443line172>
> >
> >     Any reason why we replace logger with System.out?

Use of getLogWriter() is deprecated & should be replaced with System.out.println().  The old logWriter interface wrote output to vm_XYZ.log files but now we want all output to go to stdout/stderr so it can be seen in the HTML output assembled by Gradle.


- Bruce


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44736/#review123327
-----------------------------------------------------------


On March 11, 2016, 10:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44736/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> added an assertion that the distributed system hasn't changed in between getSystem() and createRegion() calls.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java a8ea590c96334d622e1b96057f62fe4414224f13 
> 
> Diff: https://reviews.apache.org/r/44736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44736/#review123327
-----------------------------------------------------------




geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java (line 172)
<https://reviews.apache.org/r/44736/#comment185541>

    Any reason why we replace logger with System.out?


- Udo Kohlmeyer


On March 11, 2016, 10:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44736/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> added an assertion that the distributed system hasn't changed in between getSystem() and createRegion() calls.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java a8ea590c96334d622e1b96057f62fe4414224f13 
> 
> Diff: https://reviews.apache.org/r/44736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44736/#review123239
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On March 11, 2016, 10:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44736/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> added an assertion that the distributed system hasn't changed in between getSystem() and createRegion() calls.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java a8ea590c96334d622e1b96057f62fe4414224f13 
> 
> Diff: https://reviews.apache.org/r/44736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>