You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/15 15:08:49 UTC

[GitHub] [camel] bvahdat opened a new pull request #4233: BaseOptionModel#getShortName should not take watermark into account

bvahdat opened a new pull request #4233:
URL: https://github.com/apache/camel/pull/4233


   [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] bedlaj commented on pull request #4233: BaseOptionModel#getShortName should not take watermark into account

Posted by GitBox <gi...@apache.org>.
bedlaj commented on pull request #4233:
URL: https://github.com/apache/camel/pull/4233#issuecomment-692783029


   I think this is here for reason. The table on website is not readable with long keys. Please try to preview website locally against this branch to see how it looks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] bvahdat closed pull request #4233: BaseOptionModel#getShortName should not take watermark into account

Posted by GitBox <gi...@apache.org>.
bvahdat closed pull request #4233:
URL: https://github.com/apache/camel/pull/4233


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] bvahdat commented on pull request #4233: BaseOptionModel#getShortName should not take watermark into account

Posted by GitBox <gi...@apache.org>.
bvahdat commented on pull request #4233:
URL: https://github.com/apache/camel/pull/4233#issuecomment-692788706


   @oscerd @bedlaj 
   
   Thanks for your feedback. I was not aware of that visualization issue. Just noticed that as I was looking for `camel.main.durationMaxIdleSeconds` configuration option on the following page:
   
   https://camel.apache.org/components/latest/others/main.html
   
   And Chrome claimed me that option would not exist, so how I came across this issue. If I had searched for `camel.main.durationMaxIdle Seconds` then I would find it which is a bit wired.
   
   So I'm abandoning this PR.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org