You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/04 09:29:54 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6870: kvm: correctly set vm cpu topology
shwstppr opened a new pull request, #6870:
URL: https://github.com/apache/cloudstack/pull/6870
### Description
Fixes: #6807
When a custom offering is used max vCPU value may differ from the actual vCPU value therefore while applying CPU topology correct value must be used.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1353322636
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303221252
code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] StepBee commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
StepBee commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1352958117
@shwstppr @DaanHoogland Finally was able to build from source, install and test in our testing environment.
I can confirm it's working.
Many thanks for your efforts on this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1347892247
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303189001
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1347980727
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303227386
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6870)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6870&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6870&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6870&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6870&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6870&metric=new_coverage&view=list) [28.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6870&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6870&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6870&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303221169
code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1354704643
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1357386782
merging as @StepBee approves as well: https://github.com/apache/cloudstack/pull/6919#issuecomment-1352973762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303489516
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303488181
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1347891283
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1355878743
<b>Trillian test result (tid-5521)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41701 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6870-t5521-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 15.77 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3.28 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3617.24 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 76.46 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1353254942
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303188131
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1303228687
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1304367726
<b>Trillian test result (tid-31)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43098 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6870-t31-kvm-centos7.zip
Smoke tests completed. 98 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 677.70 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 426.29 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 756.25 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1273.10 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 563.87 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1353256398
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6870: kvm: correctly set vm cpu topology
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6870:
URL: https://github.com/apache/cloudstack/pull/6870#issuecomment-1354704347
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org