[GitHub] [sling-org-apache-sling-models-impl] sagarmiglani commented on a change in pull request #34: SLING-11132 - Exception handling while clearing OSGiServiceReferences

[GitBox <gi...@apache.org>]

sagarmiglani commented on a change in pull request #34:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#discussion_r803331667



##########
File path: src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java
##########
@@ -204,7 +204,11 @@ public Callback(ServiceReference<?>[] refs, BundleContext context) {
         public void onDisposed() {
             if (refs != null) {
                 for (ServiceReference<?> ref : refs) {
-                    context.ungetService(ref);
+                    try {
+                        context.ungetService(ref);
+                    } catch (IllegalStateException | IllegalArgumentException | NullPointerException exception) {

Review comment:
       Please let me know if I should replace multiple exception with a generic RuntimeException or this should be handled in a different way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org