You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zero323 <gi...@git.apache.org> on 2016/04/20 02:10:53 UTC
[GitHub] spark pull request: [SPARK-14739][WIP][PYTHON][ML]
GitHub user zero323 opened a pull request:
https://github.com/apache/spark/pull/12511
[SPARK-14739][WIP][PYTHON][ML]
## What changes were proposed in this pull request?
Fix parsing empty dense and sparse vectors, correct dead parsing tests.
## How was this patch tested?
Fixed parsing tests, added tests specific to SPARK-14739
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zero323/spark SPARK-14739
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12511
----
commit 0433338f5c20f94f1dceee3ac01fe9ff32cf4496
Author: zero323 <2a...@opayq.com>
Date: 2016-04-19T23:32:17Z
Add tests for SPARK-14739
commit f46da1b76fbdfc46ced8133b69fcb08a003ee308
Author: zero323 <2a...@opayq.com>
Date: 2016-04-19T23:20:22Z
Fix parsing for empty DenseVector
commit 6e50f77a56549dda296f4c7bfb75942e344d4890
Author: zero323 <2a...@opayq.com>
Date: 2016-04-20T00:01:54Z
Fix pre-existing tests
commit be9809a214e61faba0305254df8f9e867a70a229
Author: zero323 <2a...@opayq.com>
Date: 2016-04-19T23:26:39Z
Fix parsing of an empty SparseVector
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][WIP][PYTHON][ML]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212180938
**[Test build #56297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56297/consoleFull)** for PR 12511 at commit [`be9809a`](https://github.com/apache/spark/commit/be9809a214e61faba0305254df8f9e867a70a229).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][WIP][PYTHON][ML]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212180942
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56297/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][WIP][PYTHON][ML]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212180940
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][PYTHON][ML]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212185415
**[Test build #56301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56301/consoleFull)** for PR 12511 at commit [`fb8e615`](https://github.com/apache/spark/commit/fb8e615a2840f790d3245ea70384543a5c8a9045).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][PYTHON][ML]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212188281
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][PYTHON][ML]
Posted by zero323 <gi...@git.apache.org>.
Github user zero323 closed the pull request at:
https://github.com/apache/spark/pull/12511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][WIP][PYTHON][ML]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212180789
**[Test build #56297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56297/consoleFull)** for PR 12511 at commit [`be9809a`](https://github.com/apache/spark/commit/be9809a214e61faba0305254df8f9e867a70a229).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][PYTHON][ML]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212188117
**[Test build #56301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56301/consoleFull)** for PR 12511 at commit [`fb8e615`](https://github.com/apache/spark/commit/fb8e615a2840f790d3245ea70384543a5c8a9045).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][PYTHON][ML]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12511#issuecomment-212188282
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56301/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org