You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by shankarh <gi...@git.apache.org> on 2017/05/16 16:43:07 UTC

[GitHub] geode pull request #515: GEODE-240: Remove deprecated methods on Transaction...

GitHub user shankarh opened a pull request:

    https://github.com/apache/geode/pull/515

    GEODE-240: Remove deprecated methods on TransactionEvent

    Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from the TransactionEvent.
    Removed implementation for methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from TxEvent and TxRmtEvent.
    Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents in TxEventTestUtil.
    Changed tests to use the new utilty methods from TxEventTestUtil.
    
    Signed-off-by: Shankar <sh...@apache.org>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    Yes.  GEODE-240
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    Yes.
    - [ ] Is your initial contribution a single, squashed commit?
    Yes.
    - [ ] Does `gradlew build` run cleanly?
    Yes.
    - [ ] Have you written or updated unit tests to verify your changes?
    Yes.
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    Not applicable.
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shankarh/geode feature/GEODE-240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #515
    
----
commit bff4e8efa5368fca1a77931ae16e0d94d9e03e53
Author: shankarh <sh...@apache.org>
Date:   2017-05-16T02:47:05Z

    GEODE-240: Remove deprecated methods on TransactionEvent
    
    Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from the TransactionEvent.
    Removed implementation for methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from TxEvent and TxRmtEvent.
    Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents in TxEventTestUtil.
    Changed tests to use the new utilty methods from TxEventTestUtil.
    
    Signed-off-by: Shankar <sh...@ampool.io>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Posted by shankarh <gi...@git.apache.org>.
Github user shankarh commented on the issue:

    https://github.com/apache/geode/pull/515
  
    Thanks @ameybarve15  @dschneider-pivotal @davinash for the review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Posted by ameybarve15 <gi...@git.apache.org>.
Github user ameybarve15 commented on the issue:

    https://github.com/apache/geode/pull/515
  
    +1 LGTM
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/515
  
    This looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Posted by shankarh <gi...@git.apache.org>.
Github user shankarh commented on the issue:

    https://github.com/apache/geode/pull/515
  
    Can this PR be merged? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:

    https://github.com/apache/geode/pull/515
  
    +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #515: GEODE-240: Remove deprecated methods on Transaction...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/515


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---