[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1038094950


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java:
##########
@@ -242,6 +256,17 @@ public List<SegmentConversionResult> executeTask(PinotTaskConfig pinotTaskConfig
             new BasicHeader(FileUploadDownloadClient.CustomHeaders.SEGMENT_ZK_METADATA_CUSTOM_MAP_MODIFIER,
                 segmentZKMetadataCustomMapModifier.toJsonString());
 
+        String pushMode = configs.get(BatchConfigProperties.PUSH_MODE);

Review Comment:
   It is same thing. I have borrowed it from the rest of the code base. Can we do it as part of seperate PR since it will touch other classes as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org