You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/08 10:19:08 UTC

[GitHub] [hive] zabetak opened a new pull request, #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

zabetak opened a new pull request, #3197:
URL: https://github.com/apache/hive/pull/3197

   ### What changes were proposed in this pull request?
   1. Create logger configuration (tests only) for writing specific DataNucleus SQL queries to (new) operation log files.
   2. Add hook copying the content of datanucleus log files to session's console for use in qtests.
   3. Avoid creating appenders & files when hook is inactive.
   4. Enable the hook on certain tests with partitions and update output.
   
   ### Why are the changes needed?
   For motivation see HIVE-26126
   
   ### Does this PR introduce _any_ user-facing change?
   No, the change only affects test.
   
   ### How was this patch tested?
   See changes in .q and .q.out files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] github-actions[bot] commented on pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3197:
URL: https://github.com/apache/hive/pull/3197#issuecomment-1149304279

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] dengzhhu653 commented on pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on PR #3197:
URL: https://github.com/apache/hive/pull/3197#issuecomment-1206239524

   +1, changes look good to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3197:
URL: https://github.com/apache/hive/pull/3197#discussion_r938628492


##########
ql/src/test/results/clientpositive/llap/list_bucket_dml_9.q.out:
##########
@@ -14,6 +14,16 @@ POSTHOOK: query: create table list_bucketing_static_part_n0 (key String, value S
 POSTHOOK: type: CREATETABLE
 POSTHOOK: Output: database:default
 POSTHOOK: Output: default@list_bucketing_static_part_n0
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID", "NAME", "DB_LOCATION_URI", "DESC", "OWNER_NAME", "OWNER_TYPE", "CTLG_NAME" , "CREATE_TIME", "DB_MANAGED_LOCATION_URI", "TYPE", "DATACONNECTOR_NAME", "REMOTE_DBNAME"FROM "DBS" where "NAME" = ? and "CTLG_NAME" = ?"

Review Comment:
   Not sure if we need a space between "REMOTE_DBNAME" and FROM, but it does not related to the changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
zabetak commented on PR #3197:
URL: https://github.com/apache/hive/pull/3197#issuecomment-1149724861

   Hey bot please keep this open!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3197:
URL: https://github.com/apache/hive/pull/3197#discussion_r938632450


##########
ql/src/test/results/clientpositive/llap/list_bucket_dml_9.q.out:
##########
@@ -14,6 +14,16 @@ POSTHOOK: query: create table list_bucketing_static_part_n0 (key String, value S
 POSTHOOK: type: CREATETABLE
 POSTHOOK: Output: database:default
 POSTHOOK: Output: default@list_bucketing_static_part_n0
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID", "NAME", "DB_LOCATION_URI", "DESC", "OWNER_NAME", "OWNER_TYPE", "CTLG_NAME" , "CREATE_TIME", "DB_MANAGED_LOCATION_URI", "TYPE", "DATACONNECTOR_NAME", "REMOTE_DBNAME"FROM "DBS" where "NAME" = ? and "CTLG_NAME" = ?"

Review Comment:
   I'm a little afraid that it will generate many `Query` logs to the original though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] github-actions[bot] closed pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…
URL: https://github.com/apache/hive/pull/3197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3197:
URL: https://github.com/apache/hive/pull/3197#discussion_r938628492


##########
ql/src/test/results/clientpositive/llap/list_bucket_dml_9.q.out:
##########
@@ -14,6 +14,16 @@ POSTHOOK: query: create table list_bucketing_static_part_n0 (key String, value S
 POSTHOOK: type: CREATETABLE
 POSTHOOK: Output: database:default
 POSTHOOK: Output: default@list_bucketing_static_part_n0
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID" from "DBS""
+SQL Query : "select "DB_ID", "NAME", "DB_LOCATION_URI", "DESC", "OWNER_NAME", "OWNER_TYPE", "CTLG_NAME" , "CREATE_TIME", "DB_MANAGED_LOCATION_URI", "TYPE", "DATACONNECTOR_NAME", "REMOTE_DBNAME"FROM "DBS" where "NAME" = ? and "CTLG_NAME" = ?"

Review Comment:
   Not sure if we need a space between "REMOTE_DBNAME" and FROM, but it does not relate to the changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #3197: HIVE-26126: Allow capturing/validating SQL generated from HMS calls i…

Posted by GitBox <gi...@apache.org>.
zabetak commented on PR #3197:
URL: https://github.com/apache/hive/pull/3197#issuecomment-1206287029

   Thanks for the review @dengzhhu653 ! My main concern at the moment is that the output depends on the state of the metastore. Since we are reusing the `derby` database across tests the output depends on the number and order that tests are executed. I cannot merge this till we find a solution where the output is stable and predictable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org