You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2025/04/02 04:10:24 UTC

[PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor link for RESTful spec [celeborn]

turboFei opened a new pull request, #3200:
URL: https://github.com/apache/celeborn/pull/3200

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #3200:
URL: https://github.com/apache/celeborn/pull/3200#issuecomment-2817837997

   Thanks. merge to main(v0.6.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3200:
URL: https://github.com/apache/celeborn/pull/3200#discussion_r2024068361


##########
openapi/openapi-client/src/main/openapi3/master_rest_v1.yaml:
##########
@@ -253,16 +253,20 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/ApplicationsHeartbeatResponse'
+
+  /api/v1/applications/{appIds}:
     delete:
       tags:
         - Application
       operationId: deleteApps
       description: Delete resource of apps.
-      requestBody:
-        content:
-          application/json:
-            schema:
-              $ref: '#/components/schemas/DeleteAppsRequest'

Review Comment:
   <img width="851" alt="image" src="https://github.com/user-attachments/assets/b1d966bb-16f5-46af-b644-96c6f15a2558" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #3200:
URL: https://github.com/apache/celeborn/pull/3200#discussion_r2033507276


##########
openapi/openapi-client/src/main/openapi3/master_rest_v1.yaml:
##########
@@ -253,16 +253,20 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/ApplicationsHeartbeatResponse'
+
+  /api/v1/applications/{appIds}:

Review Comment:
   IMO, we can use `POST` method instead of `DELETE` for batch delete operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3200:
URL: https://github.com/apache/celeborn/pull/3200#discussion_r2024068561


##########
openapi/openapi-client/src/main/openapi3/worker_rest_v1.yaml:
##########
@@ -652,10 +652,8 @@ components:
       properties:
         primaryPartitions:
           $ref: '#/components/schemas/ShufflePartitionLocations'
-          default: { }
         replicaPartitions:
           $ref: '#/components/schemas/ShufflePartitionLocations'
-          default: { }

Review Comment:
   <img width="647" alt="image" src="https://github.com/user-attachments/assets/36a0db1f-0c5a-4b9c-ac19-b501d07c57de" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3200:
URL: https://github.com/apache/celeborn/pull/3200#discussion_r2051132906


##########
openapi/openapi-client/src/main/openapi3/master_rest_v1.yaml:
##########
@@ -253,16 +253,20 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/ApplicationsHeartbeatResponse'
+
+  /api/v1/applications/{appIds}:

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #3200: [CELEBORN-1436][FOLLOWUP] Add swagger editor links for RESTful spec
URL: https://github.com/apache/celeborn/pull/3200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org