You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/12/17 15:03:27 UTC
[GitHub] [dubbo] wxbty commented on a diff in pull request #11144: fix #11033
wxbty commented on code in PR #11144:
URL: https://github.com/apache/dubbo/pull/11144#discussion_r1051414127
##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/proxy/AbstractProxyInvoker.java:
##########
@@ -97,6 +99,11 @@ public Result invoke(Invocation invocation) throws RpcException {
}
}
+ Map<String, String> invocationAttachments = invocation.getAttachments();
+ if (CollectionUtils.isNotEmptyMap(invocationAttachments)) {
+ RpcContext.getClientAttachment().getObjectAttachments().putAll(invocationAttachments);
+ }
+
Review Comment:
Why does the AbstractProxyInvoker on the provider side use ClientAttachment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org