You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:21:23 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (Jiatao Tao)

vlsi commented on a change in pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#discussion_r520370387



##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode> terms,
       return e;
     }
   }
+  
+  public RexNode simplifyBoolean(RexNode call) {

Review comment:
       As I said, flattendAnd and composeConjunctions remove duplicates: https://github.com/apache/calcite/blob/d03ce47536ddb2aaec6d445b3ea48464081a7ed0/core/src/main/java/org/apache/calcite/rex/RexUtil.java#L1234




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org