You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/12/06 02:51:02 UTC
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use a actionable exc...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19903
[SPARK-20728][SQL][FOLLOWUP] Use a actionable exception message
## What changes were proposed in this pull request?
This is a follow-up to improve an exception message.
## How was this patch tested?
Pass the Jenkins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark orc_exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19903
----
commit d6cdde748fb25e51f7f100a9bbd48a1d17547ccf
Author: Dongjoon Hyun <do...@apache.org>
Date: 2017-12-06T01:19:58Z
[SPARK-20728][SQL][FOLLOWUP] Use a actionable exception message
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
Yep. The test case will be updated together.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84521/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84528/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19903
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84536/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155144120
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,8 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
- "Please use native ORC data source instead")
+ "Please use native ORC data source instead by setting 'spark.sql.orc.impl' " +
+ "configuration to 'native'")
--- End diff --
Please use the native ORC data source by setting 'spark.sql.orc.impl' to 'native'
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155145012
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,8 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
--- End diff --
Yep.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use a actionable exc...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155139961
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,7 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
- "Please use native ORC data source instead")
+ "Please use native ORC data source instead by `SET spark.sql.orc.impl=native`")
--- End diff --
Sure!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19903
Do you have a test case?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84541/testReport)** for PR 19903 at commit [`9809af8`](https://github.com/apache/spark/commit/9809af87cca925bb2ecc90c6c71ab5337695bf28).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84528/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155171122
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -601,8 +601,9 @@ object DataSource extends Logging {
if (provider1.toLowerCase(Locale.ROOT) == "orc" ||
--- End diff --
Yep. I'll remove this here since it's small.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
@cloud-fan , @HyukjinKwon , @gatorsmile . The PR is updated again.
Please let me know if I need to update more. Thank you!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84532/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
Thank you, @HyukjinKwon and @cloud-fan .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155169253
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -601,8 +601,9 @@ object DataSource extends Logging {
if (provider1.toLowerCase(Locale.ROOT) == "orc" ||
--- End diff --
As suggested in other PR, we can remove this condition.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19903
LGTM pending Jenkins on $84528
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19903
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155144800
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,8 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
- "Please use native ORC data source instead")
+ "Please use native ORC data source instead by setting 'spark.sql.orc.impl' " +
+ "configuration to 'native'")
--- End diff --
Yep.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84532/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use a actionable exc...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155136838
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,7 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
- "Please use native ORC data source instead")
+ "Please use native ORC data source instead by `SET spark.sql.orc.impl=native`")
--- End diff --
Wait .. @dongjoon-hyun can we just say like `by setting 'spark.sql.orc.impl' configuration to 'native'`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84532/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
Retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84528/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84526/testReport)** for PR 19903 at commit [`ba1e3ae`](https://github.com/apache/spark/commit/ba1e3ae39116c53a8f0d1ed7c71f737fa2e9d0b6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84536/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
Thanks, @gatorsmile .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84541/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84521/testReport)** for PR 19903 at commit [`d6cdde7`](https://github.com/apache/spark/commit/d6cdde748fb25e51f7f100a9bbd48a1d17547ccf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19903
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84526/testReport)** for PR 19903 at commit [`ba1e3ae`](https://github.com/apache/spark/commit/ba1e3ae39116c53a8f0d1ed7c71f737fa2e9d0b6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19903#discussion_r155144262
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
@@ -602,7 +602,8 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
--- End diff --
Hive built-in ORC data source must be used with Hive support enabled.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use a actionable exception ...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19903
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84541/testReport)** for PR 19903 at commit [`9809af8`](https://github.com/apache/spark/commit/9809af87cca925bb2ecc90c6c71ab5337695bf28).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84526/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19903
Thank you, @HyukjinKwon , @cloud-fan , @gatorsmile , @viirya !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable ex...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19903
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use a actionable exception ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84521/testReport)** for PR 19903 at commit [`d6cdde7`](https://github.com/apache/spark/commit/d6cdde748fb25e51f7f100a9bbd48a1d17547ccf).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19903
LGTM with one minor comment.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19903
**[Test build #84536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84536/testReport)** for PR 19903 at commit [`d7d268d`](https://github.com/apache/spark/commit/d7d268d19e69b1477e2f3ca9cc8d3f1221d3663c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org