You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/05 17:55:52 UTC
[GitHub] john-bodley commented on issue #5295: [sqllab] Fix sqllab limit
regex issue with sqlparse
john-bodley commented on issue #5295: [sqllab] Fix sqllab limit regex issue with sqlparse
URL: https://github.com/apache/incubator-superset/pull/5295#issuecomment-402804021
@timifasubaa this is generally the right approach but I sense there could be some additional simplification, i.e., I don't think we need to first i) find (and store) the limit and then go through and then ii) re-find the limit and replace it. It seems that this could all happen in the same function which would reduce the need to repeat code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org