You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/30 14:47:00 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #28955: [SPARK-25556][SPARK-17636][SPARK-31026][SPARK-31060][SQL][FOLLOW-UP] Avoids changing test utils and minimizes the diff

cloud-fan commented on a change in pull request #28955:
URL: https://github.com/apache/spark/pull/28955#discussion_r447741993



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -501,38 +508,37 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
     }
 
     val data = (1 to 4).map(i => Tuple1(Option(i.b)))
-    import testImplicits._
-    withNestedDataFrame(data.toDF()) { case (inputDF, colName, resultFun) =>

Review comment:
       I didn't review them one line by one line, assuming they just remove the outer `withNestedDataFrame`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org